all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: panel/GuestStatusView: readd necessary xtypes
@ 2021-06-24 15:11 Dominik Csapak
  2021-06-25  7:14 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-06-24 15:11 UTC (permalink / raw)
  To: pve-devel

currently, cbind only applies properties on objects which have
an 'xtype' property.

commit 38e6634a8fe8c11ec23e555ce55bc1972ccb5ea1
removed those, thinking the xtype in the 'defaults' is enough

add them back, noting that cbind does need it, to prevent removal

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
we should probably cherry-pick it into stable-6 as well

 www/manager6/panel/GuestStatusView.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js
index 8db1f492..d59476c1 100644
--- a/www/manager6/panel/GuestStatusView.js
+++ b/www/manager6/panel/GuestStatusView.js
@@ -53,6 +53,7 @@ Ext.define('PVE.panel.GuestStatusView', {
 	    itemId: 'node',
 	    iconCls: 'fa fa-building fa-fw',
 	    title: gettext('Node'),
+	    xtype: 'pmxInfoWidget', // necessary for cbind to apply
 	    cbind: {
 		text: '{pveSelNode.data.node}',
 	    },
@@ -86,6 +87,7 @@ Ext.define('PVE.panel.GuestStatusView', {
 	    title: gettext('SWAP usage'),
 	    valueField: 'swap',
 	    maxField: 'maxswap',
+	    xtype: 'pmxInfoWidget', // necessary for cbind to apply
 	    cbind: {
 		hidden: '{isQemu}',
 		disabled: '{isQemu}',
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-25  7:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 15:11 [pve-devel] [PATCH manager] ui: panel/GuestStatusView: readd necessary xtypes Dominik Csapak
2021-06-25  7:14 ` Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal