* [pve-devel] [PATCH pve-kernel-meta] proxmox-boot: redirect stdout in update-grub snippet
@ 2021-06-24 11:20 Stoiko Ivanov
2021-06-24 12:21 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2021-06-24 11:20 UTC (permalink / raw)
To: pve-devel
update-grub (via grub-mkconfig) generates the grub configuration by
concatenating the output of each snippet (from /etc/grub.d).
We need to redirect the output of `proxmox-boot-tool refresh`
to not end up with a syntactically wrong config in /boot/grub/grub.cfg
(which is not used in any case)
quickly tested with a test-installation of mine
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/proxmox-boot/000_proxmox_boot_header b/proxmox-boot/000_proxmox_boot_header
index 597f65a..106273e 100755
--- a/proxmox-boot/000_proxmox_boot_header
+++ b/proxmox-boot/000_proxmox_boot_header
@@ -18,7 +18,7 @@ if proxmox-boot-tool status --quiet; then
warn "W: Running: 'proxmox-boot-tool refresh'"
warn ""
- proxmox-boot-tool refresh
+ proxmox-boot-tool refresh > /dev/null
fi
fi
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH pve-kernel-meta] proxmox-boot: redirect stdout in update-grub snippet
2021-06-24 11:20 [pve-devel] [PATCH pve-kernel-meta] proxmox-boot: redirect stdout in update-grub snippet Stoiko Ivanov
@ 2021-06-24 12:21 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-06-24 12:21 UTC (permalink / raw)
To: Proxmox VE development discussion, Stoiko Ivanov
On 24.06.21 13:20, Stoiko Ivanov wrote:
> update-grub (via grub-mkconfig) generates the grub configuration by
> concatenating the output of each snippet (from /etc/grub.d).
>
> We need to redirect the output of `proxmox-boot-tool refresh`
> to not end up with a syntactically wrong config in /boot/grub/grub.cfg
> (which is not used in any case)
>
> quickly tested with a test-installation of mine
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> proxmox-boot/000_proxmox_boot_header | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-24 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 11:20 [pve-devel] [PATCH pve-kernel-meta] proxmox-boot: redirect stdout in update-grub snippet Stoiko Ivanov
2021-06-24 12:21 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal