[pbs-devel] [PATCH proxmox-backup] report: add disk/by-id and disk/by-path info

[pbs-devel] [PATCH proxmox-backup] report: add disk/by-id and disk/by-path info

[Aaron Lauterer]

Globbing seems to not work, e.g. `ls -l /dev/disk/*`. Therefore calling
it two times for the id and path directories as those two are the most
useful in my experience when trying to infer things about the disks and
how they are connected.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 src/server/report.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/server/report.rs b/src/server/report.rs
index e89abbc5..73f73e52 100644
--- a/src/server/report.rs
+++ b/src/server/report.rs
@@ -23,6 +23,8 @@ fn commands() -> Vec<(&'static str, Vec<&'static str>)> {
         ("proxmox-backup-manager", vec!["versions", "--verbose"]),
         ("df", vec!["-h"]),
         ("lsblk", vec!["--ascii"]),
+        ("ls", vec!["-l", "/dev/disk/by-id"]),
+        ("ls", vec!["-l", "/dev/disk/by-path"]),
         ("zpool", vec!["status"]),
         ("zfs", vec!["list"]),
         ("proxmox-backup-manager", vec!["subscription", "get"]),
-- 
2.30.2

Re: [pbs-devel] [PATCH proxmox-backup] report: add disk/by-id and disk/by-path info

[Thomas Lamprecht]

On 24.06.21 11:32, Aaron Lauterer wrote:
> Globbing seems to not work, e.g. `ls -l /dev/disk/*`. Therefore calling
> it two times for the id and path directories as those two are the most
> useful in my experience when trying to infer things about the disks and
> how they are connected.

Globbing is a shell feature not one of core-utils commands or the like, the shell
will always expand GLOBs first and the command will just see all files as arguments
(that's why one can get "argument list to large" errors when using that, thus the
existence of xargs, find's -exec and the like).

> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  src/server/report.rs | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/server/report.rs b/src/server/report.rs
> index e89abbc5..73f73e52 100644
> --- a/src/server/report.rs
> +++ b/src/server/report.rs
> @@ -23,6 +23,8 @@ fn commands() -> Vec<(&'static str, Vec<&'static str>)> {
>          ("proxmox-backup-manager", vec!["versions", "--verbose"]),
>          ("df", vec!["-h"]),
>          ("lsblk", vec!["--ascii"]),
> +        ("ls", vec!["-l", "/dev/disk/by-id"]),
> +        ("ls", vec!["-l", "/dev/disk/by-path"]),

Be the change^W GLOB you want to see, i.e., why not just expand yourself?

("ls", vec!["-l", "/dev/disk/by-id", "/dev/disk/by-path"]),

>          ("zpool", vec!["status"]),
>          ("zfs", vec!["list"]),
>          ("proxmox-backup-manager", vec!["subscription", "get"]),
>