From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH container] fix #3367: skip bind mounts when converting to template
Date: Mon, 21 Jun 2021 10:41:08 +0200 [thread overview]
Message-ID: <20210621084108.vjilobjck6kme4hb@olga.proxmox.com> (raw)
In-Reply-To: <62c7149e-d029-295f-2a38-102fae14889a@proxmox.com>
On Tue, Apr 06, 2021 at 08:26:50AM +0200, Fabian Ebner wrote:
> It turns out that we do not yet allow cloning from container templates with
> bind mounts. So in a sense container templates with bind mounts are
> currently misconfigured, and this patch would make it easier to get there...
>
> Should I send a v2 with a patch making cloning from such templates possible,
> or were there some concerns to not allow it in the first place? There is a
> # TODO: allow bind mounts?
> comment in the clone API call.
It's mostly that bind mounts are generally root-only.
Silently dropping them when converting to a template seems awkward, I'd
rather have this throw an error, too.
(Also remember that containers don't need to be templates to be cloned.)
next prev parent reply other threads:[~2021-06-21 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 12:36 Fabian Ebner
2021-04-06 6:26 ` Fabian Ebner
2021-06-21 8:41 ` Wolfgang Bumiller [this message]
2021-06-22 7:20 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621084108.vjilobjck6kme4hb@olga.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.