all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES] stricter storage rules for migration
Date: Fri, 18 Jun 2021 12:59:29 +0200	[thread overview]
Message-ID: <20210618105938.57107-1-f.ebner@proxmox.com> (raw)

Enforce that affected storages are enabled and have the correct content type
before doing a migration. And only pick up unreferenced guest volumes from
storages that support the content type.

Can be considered a breaking change, but it'll only affect scenarios where there
is a guest's volume on a misconfigured storage, so it can also be considered a
bug fix. Still, best to do it for a major release.

Another small change regarding misconfigured 'none' content type is thrown in,
patches storage #2 and manager #2, which also should rather be done for a major
release.


Dependency-wise, only patch storage #1 is relevant, as it breaks older migration
code, but should also be limited to scenarios with unused/unreferenced/vmstate
local disks *and* misconfigured storage.


pve-container:

Fabian Ebner (3):
  prefer storage_check_enabled over storage_check_node
  migrate: also test unused volumes
  migrate: enforce that rootdir content type is available


qemu-server:

Fabian Ebner (2):
  prefer storage_check_enabled over storage_check_node
  migrate: enforce that image content type is available

 PVE/API2/Qemu.pm   |  4 ++--
 PVE/QemuMigrate.pm | 31 +++++++++++++++++++------------
 PVE/QemuServer.pm  |  7 +++++--
 3 files changed, 26 insertions(+), 16 deletions(-)


pve-storage:

Fabian Ebner (2):
  vdisk_list: only scan storages with the correct content type(s)
  config: prevent empty content list when content type 'none' is not
    supported

 PVE/Storage.pm        | 8 ++------
 PVE/Storage/Plugin.pm | 4 ++++
 2 files changed, 6 insertions(+), 6 deletions(-)


pve-manager:

Fabian Ebner (2):
  pve6to7: add check for guest images on misconfigured storages
  pve6to7: check for misconfigured content type 'none'

 PVE/CLI/pve6to7.pm | 50 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

-- 
2.20.1





             reply	other threads:[~2021-06-18 11:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 10:59 Fabian Ebner [this message]
2021-06-18 10:59 ` [pve-devel] [PATCH container 1/3] prefer storage_check_enabled over storage_check_node Fabian Ebner
2021-06-21  8:42   ` [pve-devel] applied: " Thomas Lamprecht
2021-06-18 10:59 ` [pve-devel] [PATCH container 2/3] migrate: also test unused volumes Fabian Ebner
2021-06-21  8:42   ` [pve-devel] applied: " Thomas Lamprecht
2021-06-18 10:59 ` [pve-devel] [PATCH container 3/3] migrate: enforce that rootdir content type is available Fabian Ebner
2021-06-21  8:42   ` [pve-devel] applied: " Thomas Lamprecht
2021-06-18 10:59 ` [pve-devel] [PATCH qemu-server 1/2] prefer storage_check_enabled over storage_check_node Fabian Ebner
2021-06-21  9:18   ` [pve-devel] applied: " Thomas Lamprecht
2021-06-18 10:59 ` [pve-devel] [PATCH qemu-server 2/2] migrate: enforce that image content type is available Fabian Ebner
2021-06-21  9:18   ` [pve-devel] applied: " Thomas Lamprecht
2021-06-18 10:59 ` [pve-devel] [PATCH storage 1/2] vdisk_list: only scan storages with the correct content type(s) Fabian Ebner
2021-06-21  9:22   ` [pve-devel] applied: " Thomas Lamprecht
2021-06-18 10:59 ` [pve-devel] [PATCH storage 2/2] config: prevent empty content list when content type 'none' is not supported Fabian Ebner
2021-06-21  9:22   ` [pve-devel] applied: " Thomas Lamprecht
2021-06-18 10:59 ` [pve-devel] [PATCH manager 1/2] pve6to7: add check for guest images on misconfigured storages Fabian Ebner
2021-06-21  9:25   ` Thomas Lamprecht
2021-06-18 10:59 ` [pve-devel] [PATCH manager 2/2] pve6to7: check for misconfigured content type 'none' Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210618105938.57107-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal