all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: file-restore: start the file-restore on the selected node
@ 2021-06-10  7:37 Dominik Csapak
  2021-06-10  8:23 ` Stefan Reiter
  0 siblings, 1 reply; 7+ messages in thread
From: Dominik Csapak @ 2021-06-10  7:37 UTC (permalink / raw)
  To: pve-devel

and not the node where the browser connects.
there are at least two good reasons for this:
* it is confusing, since the user would expect it to start where
  the ui is pointint to
* the storage may not be available on the node the browser connects
  to, but it must be available on the node selected in the ui

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/grid/BackupView.js    | 4 ++--
 www/manager6/storage/BackupView.js | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index 8825ed96..fbed4118 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -247,8 +247,8 @@ Ext.define('PVE.grid.BackupView', {
 		let isVMArchive = PVE.Utils.volume_is_qemu_backup(rec.data.volid, rec.data.format);
 		Ext.create('Proxmox.window.FileBrowser', {
 		    title: gettext('File Restore') + " - " + rec.data.text,
-		    listURL: `/api2/json/nodes/localhost/storage/${storage}/file-restore/list`,
-		    downloadURL: `/api2/json/nodes/localhost/storage/${storage}/file-restore/download`,
+		    listURL: `/api2/json/nodes/${nodename}/storage/${storage}/file-restore/list`,
+		    downloadURL: `/api2/json/nodes/${nodename}/storage/${storage}/file-restore/download`,
 		    extraParams: {
 			volume: rec.data.volid,
 		    },
diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js
index 0613c94d..c287ec63 100644
--- a/www/manager6/storage/BackupView.js
+++ b/www/manager6/storage/BackupView.js
@@ -114,8 +114,8 @@ Ext.define('PVE.storage.BackupView', {
 		    let isVMArchive = PVE.Utils.volume_is_qemu_backup(rec.data.volid, rec.data.format);
 		    Ext.create('Proxmox.window.FileBrowser', {
 			title: gettext('File Restore') + " - " + rec.data.text,
-			listURL: `/api2/json/nodes/localhost/storage/${me.storage}/file-restore/list`,
-			downloadURL: `/api2/json/nodes/localhost/storage/${me.storage}/file-restore/download`,
+			listURL: `/api2/json/nodes/${nodename}/storage/${me.storage}/file-restore/list`,
+			downloadURL: `/api2/json/nodes/${nodename}/storage/${me.storage}/file-restore/download`,
 			extraParams: {
 			    volume: rec.data.volid,
 			},
-- 
2.20.1





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-06-21  9:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10  7:37 [pve-devel] [PATCH manager] ui: file-restore: start the file-restore on the selected node Dominik Csapak
2021-06-10  8:23 ` Stefan Reiter
2021-06-10  8:40   ` Dominik Csapak
2021-06-10  9:29     ` Stefan Reiter
2021-06-10 11:28       ` Dominik Csapak
2021-06-18 15:17         ` Thomas Lamprecht
2021-06-21  9:38           ` Stefan Reiter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal