all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: file-restore: start the file-restore on the selected node
Date: Thu, 10 Jun 2021 09:37:19 +0200	[thread overview]
Message-ID: <20210610073719.26504-1-d.csapak@proxmox.com> (raw)

and not the node where the browser connects.
there are at least two good reasons for this:
* it is confusing, since the user would expect it to start where
  the ui is pointint to
* the storage may not be available on the node the browser connects
  to, but it must be available on the node selected in the ui

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/grid/BackupView.js    | 4 ++--
 www/manager6/storage/BackupView.js | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index 8825ed96..fbed4118 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -247,8 +247,8 @@ Ext.define('PVE.grid.BackupView', {
 		let isVMArchive = PVE.Utils.volume_is_qemu_backup(rec.data.volid, rec.data.format);
 		Ext.create('Proxmox.window.FileBrowser', {
 		    title: gettext('File Restore') + " - " + rec.data.text,
-		    listURL: `/api2/json/nodes/localhost/storage/${storage}/file-restore/list`,
-		    downloadURL: `/api2/json/nodes/localhost/storage/${storage}/file-restore/download`,
+		    listURL: `/api2/json/nodes/${nodename}/storage/${storage}/file-restore/list`,
+		    downloadURL: `/api2/json/nodes/${nodename}/storage/${storage}/file-restore/download`,
 		    extraParams: {
 			volume: rec.data.volid,
 		    },
diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js
index 0613c94d..c287ec63 100644
--- a/www/manager6/storage/BackupView.js
+++ b/www/manager6/storage/BackupView.js
@@ -114,8 +114,8 @@ Ext.define('PVE.storage.BackupView', {
 		    let isVMArchive = PVE.Utils.volume_is_qemu_backup(rec.data.volid, rec.data.format);
 		    Ext.create('Proxmox.window.FileBrowser', {
 			title: gettext('File Restore') + " - " + rec.data.text,
-			listURL: `/api2/json/nodes/localhost/storage/${me.storage}/file-restore/list`,
-			downloadURL: `/api2/json/nodes/localhost/storage/${me.storage}/file-restore/download`,
+			listURL: `/api2/json/nodes/${nodename}/storage/${me.storage}/file-restore/list`,
+			downloadURL: `/api2/json/nodes/${nodename}/storage/${me.storage}/file-restore/download`,
 			extraParams: {
 			    volume: rec.data.volid,
 			},
-- 
2.20.1





             reply	other threads:[~2021-06-10  7:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  7:37 Dominik Csapak [this message]
2021-06-10  8:23 ` Stefan Reiter
2021-06-10  8:40   ` Dominik Csapak
2021-06-10  9:29     ` Stefan Reiter
2021-06-10 11:28       ` Dominik Csapak
2021-06-18 15:17         ` Thomas Lamprecht
2021-06-21  9:38           ` Stefan Reiter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610073719.26504-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal