all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: ceph/Pools: defuse min_size warning
Date: Mon,  7 Jun 2021 12:31:58 +0200	[thread overview]
Message-ID: <20210607103158.21038-1-d.csapak@proxmox.com> (raw)

we should not warn for the ceph built-in default warnings for min_size
having the min_size half of the size (rounded up) is ok and
even the default for ceph

since there seems to be no 'quorum based' pg inconsistency recovery[0],
only a copy from the authoritative osd, there is nothing wrong
with setting that.

0: https://docs.ceph.com/en/latest/rados/operations/pg-repair/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/ceph/Pool.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 41c08c39..41df216e 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -28,7 +28,7 @@ Ext.define('PVE.CephPoolInputPanel', {
 	    allowBlank: false,
 	    listeners: {
 		change: function(field, val) {
-		    let size = Math.round((val + 1) / 2);
+		    let size = Math.round(val / 2);
 		    if (size > 1) {
 			field.up('inputpanel').down('field[name=min_size]').setValue(size);
 		    }
@@ -82,7 +82,7 @@ Ext.define('PVE.CephPoolInputPanel', {
 		    let panel = field.up('inputpanel');
 		    let size = panel.down('field[name=size]').getValue();
 
-		    let showWarning = minSize <= size / 2 && minSize !== size;
+		    let showWarning = minSize < (size / 2) && minSize !== size;
 
 		    let fieldLabel = gettext('Min. Size');
 		    if (showWarning) {
@@ -97,7 +97,7 @@ Ext.define('PVE.CephPoolInputPanel', {
 	    xtype: 'displayfield',
 	    name: 'min_size-warning',
 	    userCls: 'pmx-hint',
-	    value: gettext('min_size <= size/2 can lead to data loss, incomplete PGs or unfound objects.'),
+	    value: gettext('min_size < size/2 can lead to data loss, incomplete PGs or unfound objects.'),
 	    hidden: true,
 	},
 	{
-- 
2.20.1





             reply	other threads:[~2021-06-07 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 10:31 Dominik Csapak [this message]
2021-06-07 10:32 ` Dominik Csapak
2021-06-18 15:19 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607103158.21038-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal