all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: datastore/DataStoreListSummary: catch and show errors per datastore
Date: Tue,  1 Jun 2021 15:35:05 +0200	[thread overview]
Message-ID: <20210601133506.28376-1-d.csapak@proxmox.com> (raw)

so that the update does not get canceled because of a bad datastore
hide the irrelevant fields in that case

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/datastore/DataStoreListSummary.js | 35 +++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/www/datastore/DataStoreListSummary.js b/www/datastore/DataStoreListSummary.js
index a9a8481a..eb9e04e1 100644
--- a/www/datastore/DataStoreListSummary.js
+++ b/www/datastore/DataStoreListSummary.js
@@ -21,6 +21,7 @@ Ext.define('PBS.datastore.DataStoreListSummary', {
 	    full: "N/A",
 	    stillbad: 0,
 	    deduplication: 1.0,
+	    error: "",
 	},
     },
     setTasks: function(taskdata, since) {
@@ -32,6 +33,13 @@ Ext.define('PBS.datastore.DataStoreListSummary', {
 	let me = this;
 	let vm = me.getViewModel();
 
+	if (statusData.error !== undefined) {
+	    vm.set('error', statusData.error);
+	    return;
+	} else {
+	    vm.set('error', "");
+	}
+
 	let usage = statusData.used/statusData.total;
 	let usagetext = Ext.String.format(gettext('{0} of {1}'),
 	    Proxmox.Utils.format_size(statusData.used),
@@ -83,12 +91,34 @@ Ext.define('PBS.datastore.DataStoreListSummary', {
 	    },
 
 	    items: [
+		{
+		    xtype: 'box',
+		    reference: 'errorBox',
+		    hidden: true,
+		    tpl: [
+			'<center>',
+			`<h3>${gettext("Error")}</h3>`,
+			'<i class="fa fa-5x fa-exclamation-circle critical"></i>',
+			'<br /><br/>',
+			'{text}',
+			'</center>',
+		    ],
+		    bind: {
+			visible: '{error}',
+			data: {
+			    text: '{error}',
+			},
+		    },
+		},
 		{
 		    xtype: 'proxmoxGauge',
 		    warningThreshold: 0.8,
 		    criticalThreshold: 0.95,
 		    flex: 1,
 		    reference: 'usage',
+		    bind: {
+			visible: '{!error}',
+		    },
 		},
 		{
 		    xtype: 'pmxInfoWidget',
@@ -99,6 +129,7 @@ Ext.define('PBS.datastore.DataStoreListSummary', {
 			data: {
 			    text: '{full}',
 			},
+			visible: '{!error}',
 		    },
 		},
 		{
@@ -110,6 +141,7 @@ Ext.define('PBS.datastore.DataStoreListSummary', {
 			data: {
 			    text: '{deduplication}',
 			},
+			visible: '{!error}',
 		    },
 		},
 		{
@@ -143,6 +175,9 @@ Ext.define('PBS.datastore.DataStoreListSummary', {
 		    reference: 'historychart',
 		    title: gettext('Usage History'),
 		    height: 100,
+		    bind: {
+			visible: '{!error}',
+		    },
 		},
 		{
 		    xtype: 'container',
-- 
2.20.1





             reply	other threads:[~2021-06-01 13:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 13:35 Dominik Csapak [this message]
2021-06-01 13:35 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: dashboard/TaskSummary: add type 'close' to the close tool Dominik Csapak
2021-06-01 14:40   ` [pbs-devel] applied: " Thomas Lamprecht
2021-06-01 14:39 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: datastore/DataStoreListSummary: catch and show errors per datastore Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210601133506.28376-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal