* [pve-devel] [PATCH manager] ui: ceph/Status: fix icon in status grid
@ 2021-05-27 11:42 Dominik Csapak
2021-06-18 15:25 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-05-27 11:42 UTC (permalink / raw)
To: pve-devel
there was a spurious leftover single quote("'"), that prevented
the correct css class to be inserted
(e.g., fa-exclamation' instead of fa-exclamation)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/ceph/Status.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js
index cd6d002b..e92c698b 100644
--- a/www/manager6/ceph/Status.js
+++ b/www/manager6/ceph/Status.js
@@ -86,7 +86,7 @@ Ext.define('PVE.node.CephStatus', {
renderer: function(value) {
let health = PVE.Utils.map_ceph_health[value];
let icon = PVE.Utils.get_health_icon(health);
- return `<i class="fa fa-fw ${icon}'"></i>`;
+ return `<i class="fa fa-fw ${icon}"></i>`;
},
sorter: {
sorterFn: function(a, b) {
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: ceph/Status: fix icon in status grid
2021-05-27 11:42 [pve-devel] [PATCH manager] ui: ceph/Status: fix icon in status grid Dominik Csapak
@ 2021-06-18 15:25 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-06-18 15:25 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 27.05.21 13:42, Dominik Csapak wrote:
> there was a spurious leftover single quote("'"), that prevented
> the correct css class to be inserted
> (e.g., fa-exclamation' instead of fa-exclamation)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/ceph/Status.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js
> index cd6d002b..e92c698b 100644
> --- a/www/manager6/ceph/Status.js
> +++ b/www/manager6/ceph/Status.js
> @@ -86,7 +86,7 @@ Ext.define('PVE.node.CephStatus', {
> renderer: function(value) {
> let health = PVE.Utils.map_ceph_health[value];
> let icon = PVE.Utils.get_health_icon(health);
> - return `<i class="fa fa-fw ${icon}'"></i>`;
> + return `<i class="fa fa-fw ${icon}"></i>`;
> },
> sorter: {
> sorterFn: function(a, b) {
>
Seems I already applied this a few weeks ago and forgot to reply:
https://git.proxmox.com/?p=pve-manager.git;a=commit;h=c3b2a34528b40d000564c492cc0fd5ce69432c02
Any how, now I also did the missing cherry-pick to stable-6, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-18 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 11:42 [pve-devel] [PATCH manager] ui: ceph/Status: fix icon in status grid Dominik Csapak
2021-06-18 15:25 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal