all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui 3/4] MainView: use new beforeChangePath signature
Date: Wed, 26 May 2021 11:13:11 +0200	[thread overview]
Message-ID: <20210526091312.20930-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210526091312.20930-1-d.csapak@proxmox.com>

subpath can be optional in extjs 7.0, so handle that

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/MainView.js | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/js/MainView.js b/js/MainView.js
index 9ebd065..0382d1f 100644
--- a/js/MainView.js
+++ b/js/MainView.js
@@ -17,9 +17,15 @@ Ext.define('PMG.MainView', {
 	    },
 	},
 
-	beforeChangePath: function(path, subpath, action) {
+	beforeChangePath: function(path, subpathOrAction, action) {
 	    let me = this;
 
+	    let subpath = subpathOrAction;
+	    if (!action) {
+		action = subpathOrAction;
+		subpath = undefined;
+	    }
+
 	    if (!Ext.ClassManager.getByAlias('widget.'+ path)) {
 		console.warn('xtype "'+path+'" not found');
 		action.stop();
-- 
2.20.1





  parent reply	other threads:[~2021-05-26  9:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  9:13 [pmg-devel] [PATCH pmg-gui 0/4] fixes/changes extjs 7.0 Dominik Csapak
2021-05-26  9:13 ` [pmg-devel] [PATCH pmg-gui 1/4] change ui to 'pve-nav' Dominik Csapak
2021-05-26  9:13 ` [pmg-devel] [PATCH pmg-gui 2/4] {Attachment, Spam, Virus}Quarantine: fix layout for iframe Dominik Csapak
2021-05-26  9:13 ` Dominik Csapak [this message]
2021-05-26  9:13 ` [pmg-devel] [PATCH pmg-gui 4/4] MainView: fix redirectTo call Dominik Csapak
2021-06-11 13:19 ` [pmg-devel] applied-series: [PATCH pmg-gui 0/4] fixes/changes extjs 7.0 Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526091312.20930-4-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal