all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Oguz Bektas <o.bektas@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container] setup: make randomize_crontab a state subroutine
Date: Tue, 25 May 2021 15:15:59 +0200	[thread overview]
Message-ID: <20210525131559.1007131-1-o.bektas@proxmox.com> (raw)

for consistency in post_create_hook. still works as expected

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 src/PVE/LXC/Setup/Base.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
index d73335b..be41874 100644
--- a/src/PVE/LXC/Setup/Base.pm
+++ b/src/PVE/LXC/Setup/Base.pm
@@ -422,7 +422,7 @@ sub set_user_authorized_ssh_keys {
     $self->ct_modify_file("$home/.ssh/authorized_keys", $ssh_keys, perms => 0700);
 }
 
-my $randomize_crontab = sub {
+sub randomize_crontab {
     my ($self, $conf) = @_;
 
     my @files;
@@ -450,7 +450,7 @@ my $randomize_crontab = sub {
 	}
 	$self->ct_file_set_contents($filename, $new);
    }
-};
+}
 
 sub set_timezone {
     my ($self, $conf) = @_;
@@ -493,7 +493,7 @@ sub post_create_hook {
 
     $self->template_fixup($conf);
 
-    &$randomize_crontab($self, $conf);
+    $self->randomize_crontab($conf);
 
     $self->set_user_password($conf, 'root', $root_password);
     $self->set_user_authorized_ssh_keys($conf, 'root', $ssh_keys) if $ssh_keys;
-- 
2.20.1




             reply	other threads:[~2021-05-25 13:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 13:15 Oguz Bektas [this message]
2021-05-25 13:26 ` Thomas Lamprecht
2021-05-26  8:48   ` Oguz Bektas
2021-05-26  9:08     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525131559.1007131-1-o.bektas@proxmox.com \
    --to=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal