all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/3] ui: Parser: fix bind and dev mounts for lxc
Date: Thu, 20 May 2021 16:59:14 +0200	[thread overview]
Message-ID: <20210520145916.23222-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210520145916.23222-1-d.csapak@proxmox.com>

match returns 'null' if the regex does not match, which is not
destructurable. so we have to save the match and check if it valid

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/Parser.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js
index 1db82331..bb6a9a33 100644
--- a/www/manager6/Parser.js
+++ b/www/manager6/Parser.js
@@ -367,9 +367,9 @@ Ext.define('PVE.Parser', {
 	    return undefined;
 	}
 
-	const [, storage] = res.file.match(/^([a-z][a-z0-9\-_.]*[a-z0-9]):/i);
-	if (storage) {
-	    res.storage = storage;
+	const match = res.file.match(/^([a-z][a-z0-9\-_.]*[a-z0-9]):/i);
+	if (match) {
+	    res.storage = match[1];
 	    res.type = 'volume';
 	} else if (res.file.match(/^\/dev\//)) {
 	    res.type = 'device';
-- 
2.20.1





  reply	other threads:[~2021-05-20 14:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 14:59 [pve-devel] [PATCH manager 0/3] some small ui fixes Dominik Csapak
2021-05-20 14:59 ` Dominik Csapak [this message]
2021-05-20 14:59 ` [pve-devel] [PATCH manager 2/3] ui: dc/RoleView: add variableRowHeight Dominik Csapak
2021-05-20 14:59 ` [pve-devel] [PATCH manager 3/3] ui: ResourceGrid: correctly remove ResourceStore listener Dominik Csapak
2021-05-20 19:05 ` [pve-devel] applied-series: [PATCH manager 0/3] some small ui fixes Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210520145916.23222-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal