all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 3/9] nodes: startall: correctly handle warning status for delayed task
Date: Wed, 12 May 2021 14:32:52 +0200	[thread overview]
Message-ID: <20210512123258.28178-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210512123258.28178-1-f.ebner@proxmox.com>

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/API2/Nodes.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index e58d9c10..1efba772 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -1810,7 +1810,7 @@ __PACKAGE__->register_method ({
 			}
 
 			my $status = PVE::Tools::upid_read_status($upid);
-			if ($status eq 'OK') {
+			if (!PVE::Tools::upid_status_is_error($status)) {
 			    # use default delay to reduce load
 			    my $delay = defined($d->{up}) ? int($d->{up}) : $default_delay;
 			    if ($delay > 0) {
-- 
2.20.1





  parent reply	other threads:[~2021-05-12 12:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 12:32 [pve-devel] [PATCH-SERIES] correctly handle warnings status Fabian Ebner
2021-05-12 12:32 ` [pve-devel] [PATCH common 1/9] tools: add upid_status_is_error function Fabian Ebner
2021-06-17 13:23   ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 2/9] api/cli: tasks: don't treat warnings status as an error status Fabian Ebner
2021-06-24  7:06   ` Thomas Lamprecht
2021-05-12 12:32 ` Fabian Ebner [this message]
2021-06-24  7:04   ` [pve-devel] applied: [PATCH manager 3/9] nodes: startall: correctly handle warning status for delayed task Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 4/9] cli: pveam: remove unused private sub Fabian Ebner
2021-06-24  7:04   ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 5/9] cli tools: correctly handle warnings status Fabian Ebner
2021-06-24  7:04   ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH storage 6/9] api: content: correctly handle warnings status for delayed task Fabian Ebner
2021-06-23 20:22   ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH container 7/9] pct: correctly handle warnings task status Fabian Ebner
2021-06-23 20:17   ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH qemu-server 8/9] cli tools: " Fabian Ebner
2021-06-23 10:53   ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH qemu-server 9/9] api: update vm: correctly handle warnings status for delayed task Fabian Ebner
2021-06-23 10:53   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210512123258.28178-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal