all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox/proxmox-backup] fix some proxmox-tape calls
Date: Fri, 30 Apr 2021 14:51:54 +0200	[thread overview]
Message-ID: <20210430125156.20072-1-d.csapak@proxmox.com> (raw)

we sometimes forgot to remove 'output-format' from the 'params'
variable, which we used for the local api call, resulting in an
invalid parameter error

fixing it by adding a 'extract_output_format' in addition to
'get_output_format' and using that where we need it

ofc, proxmox-backup needs to depend on a bumped version of proxmox
for this to work

proxmox:

Dominik Csapak (1):
  proxmox/api/cli: add extract_output_format

 proxmox/src/api/cli/text_table.rs | 12 ++++++++++++
 1 file changed, 12 insertions(+)

proxmox-backup:

Dominik Csapak (1):
  bin: use extract_output_format where necessary

 src/bin/proxmox-backup-client.rs |  3 +--
 src/bin/proxmox-tape.rs          | 32 ++++++++++++++++----------------
 2 files changed, 17 insertions(+), 18 deletions(-)

-- 
2.20.1





             reply	other threads:[~2021-04-30 12:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30 12:51 Dominik Csapak [this message]
2021-04-30 12:51 ` [pbs-devel] [PATCH proxmox 1/1] proxmox/api/cli: add extract_output_format Dominik Csapak
2021-05-03  7:03   ` [pbs-devel] applied: " Dietmar Maurer
2021-04-30 12:51 ` [pbs-devel] [PATCH proxmox-backup 1/1] bin: use extract_output_format where necessary Dominik Csapak
2021-05-03  7:04   ` [pbs-devel] applied: " Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210430125156.20072-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal