* [pbs-devel] [PATCH proxmox-backup] ui: tape: ChangerStatus fixup for empty barcode
@ 2021-04-30 9:46 Dominik Csapak
2021-05-14 6:49 ` [pbs-devel] applied: " Dietmar Maurer
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-04-30 9:46 UTC (permalink / raw)
To: pbs-devel
empty barcode means that label-text is '', not undefined
we forgot this line
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/ChangerStatus.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index f4bcc631..51ba6ffa 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -224,7 +224,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
return `${url}/${encodeURIComponent(drive)}/${apiCall}`;
},
items: [
- label !== undefined ? {
+ label !== "" ? {
xtype: 'displayfield',
name: 'label-text',
value: label,
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] ui: tape: ChangerStatus fixup for empty barcode
2021-04-30 9:46 [pbs-devel] [PATCH proxmox-backup] ui: tape: ChangerStatus fixup for empty barcode Dominik Csapak
@ 2021-05-14 6:49 ` Dietmar Maurer
0 siblings, 0 replies; 2+ messages in thread
From: Dietmar Maurer @ 2021-05-14 6:49 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
applied
On 4/30/21 11:46 AM, Dominik Csapak wrote:
> empty barcode means that label-text is '', not undefined
> we forgot this line
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/tape/ChangerStatus.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
> index f4bcc631..51ba6ffa 100644
> --- a/www/tape/ChangerStatus.js
> +++ b/www/tape/ChangerStatus.js
> @@ -224,7 +224,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
> return `${url}/${encodeURIComponent(drive)}/${apiCall}`;
> },
> items: [
> - label !== undefined ? {
> + label !== "" ? {
> xtype: 'displayfield',
> name: 'label-text',
> value: label,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-14 6:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-30 9:46 [pbs-devel] [PATCH proxmox-backup] ui: tape: ChangerStatus fixup for empty barcode Dominik Csapak
2021-05-14 6:49 ` [pbs-devel] applied: " Dietmar Maurer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal