* [pve-devel] [PATCH proxmox-backup] file-restore: fix package name for kernel/initramfs image
@ 2021-04-27 8:48 ` Stefan Reiter
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Reiter @ 2021-04-27 8:48 UTC (permalink / raw)
To: pbs-devel, pve-devel
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
Note that 'proxmox-backup-restore-image' is listed as 'recommended', not
'depends', which somewhat makes sense, as CT restore works without it as well,
but maybe we should include it in the PVE installation ISO somehow? Or just make
it a depends? atm after installing a fresh PVE, the 'File Restore' button for
VMs only shows this message until a user manually installs this package.
src/bin/proxmox_file_restore/qemu_helper.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/proxmox_file_restore/qemu_helper.rs b/src/bin/proxmox_file_restore/qemu_helper.rs
index 0f3a7feb..bb16bf14 100644
--- a/src/bin/proxmox_file_restore/qemu_helper.rs
+++ b/src/bin/proxmox_file_restore/qemu_helper.rs
@@ -51,7 +51,7 @@ fn validate_img_existance() -> Result<(), Error> {
let kernel = PathBuf::from(buildcfg::PROXMOX_BACKUP_KERNEL_FN);
let initramfs = PathBuf::from(buildcfg::PROXMOX_BACKUP_INITRAMFS_FN);
if !kernel.exists() || !initramfs.exists() {
- bail!("cannot run file-restore VM: package 'proxmox-file-restore' is not (correctly) installed");
+ bail!("cannot run file-restore VM: package 'proxmox-backup-restore-image' is not (correctly) installed");
}
Ok(())
}
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [pbs-devel] [PATCH proxmox-backup] file-restore: fix package name for kernel/initramfs image
@ 2021-04-27 8:48 ` Stefan Reiter
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Reiter @ 2021-04-27 8:48 UTC (permalink / raw)
To: pbs-devel, pve-devel
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
Note that 'proxmox-backup-restore-image' is listed as 'recommended', not
'depends', which somewhat makes sense, as CT restore works without it as well,
but maybe we should include it in the PVE installation ISO somehow? Or just make
it a depends? atm after installing a fresh PVE, the 'File Restore' button for
VMs only shows this message until a user manually installs this package.
src/bin/proxmox_file_restore/qemu_helper.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/proxmox_file_restore/qemu_helper.rs b/src/bin/proxmox_file_restore/qemu_helper.rs
index 0f3a7feb..bb16bf14 100644
--- a/src/bin/proxmox_file_restore/qemu_helper.rs
+++ b/src/bin/proxmox_file_restore/qemu_helper.rs
@@ -51,7 +51,7 @@ fn validate_img_existance() -> Result<(), Error> {
let kernel = PathBuf::from(buildcfg::PROXMOX_BACKUP_KERNEL_FN);
let initramfs = PathBuf::from(buildcfg::PROXMOX_BACKUP_INITRAMFS_FN);
if !kernel.exists() || !initramfs.exists() {
- bail!("cannot run file-restore VM: package 'proxmox-file-restore' is not (correctly) installed");
+ bail!("cannot run file-restore VM: package 'proxmox-backup-restore-image' is not (correctly) installed");
}
Ok(())
}
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [pve-devel] applied: [pbs-devel] [PATCH proxmox-backup] file-restore: fix package name for kernel/initramfs image
2021-04-27 8:48 ` [pbs-devel] " Stefan Reiter
@ 2021-04-27 9:18 ` Thomas Lamprecht
-1 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2021-04-27 9:18 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Stefan Reiter, pve-devel
On 27.04.21 10:48, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> Note that 'proxmox-backup-restore-image' is listed as 'recommended', not
> 'depends', which somewhat makes sense, as CT restore works without it as well,
> but maybe we should include it in the PVE installation ISO somehow? Or just make
> it a depends? atm after installing a fresh PVE, the 'File Restore' button for
> VMs only shows this message until a user manually installs this package.
>
sure, mistake on my part.
> src/bin/proxmox_file_restore/qemu_helper.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] file-restore: fix package name for kernel/initramfs image
@ 2021-04-27 9:18 ` Thomas Lamprecht
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2021-04-27 9:18 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Stefan Reiter, pve-devel
On 27.04.21 10:48, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> Note that 'proxmox-backup-restore-image' is listed as 'recommended', not
> 'depends', which somewhat makes sense, as CT restore works without it as well,
> but maybe we should include it in the PVE installation ISO somehow? Or just make
> it a depends? atm after installing a fresh PVE, the 'File Restore' button for
> VMs only shows this message until a user manually installs this package.
>
sure, mistake on my part.
> src/bin/proxmox_file_restore/qemu_helper.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-27 9:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 8:48 [pve-devel] [PATCH proxmox-backup] file-restore: fix package name for kernel/initramfs image Stefan Reiter
2021-04-27 8:48 ` [pbs-devel] " Stefan Reiter
2021-04-27 9:18 ` [pve-devel] applied: " Thomas Lamprecht
2021-04-27 9:18 ` [pbs-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal