* [pve-devel] [PATCH manager] ui: add comment about disabling spice/xterm initially
@ 2021-04-21 13:02 Dominik Csapak
2021-04-21 15:29 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-04-21 13:02 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
@thomas: tried again to reproduce your issue, but could not, choosing
a specific console type in datacenter->options resulted in the ui
choosing that (when available) or falling back to the 'best' method
available
did you maybe try from a different window without refreshing?
we only check that value once in the beginning, or when you change
it in the same tab
www/manager6/qemu/Config.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
index b5f8cc9c..108df69b 100644
--- a/www/manager6/qemu/Config.js
+++ b/www/manager6/qemu/Config.js
@@ -199,6 +199,7 @@ Ext.define('PVE.qemu.Config', {
disabled: !caps.vms['VM.Console'],
hidden: template,
consoleType: 'kvm',
+ // disable spice/xterm for default action until status api call succeeded
enableSpice: false,
enableXtermjs: false,
consoleName: vm.name,
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: add comment about disabling spice/xterm initially
2021-04-21 13:02 [pve-devel] [PATCH manager] ui: add comment about disabling spice/xterm initially Dominik Csapak
@ 2021-04-21 15:29 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-04-21 15:29 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 21.04.21 15:02, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> @thomas: tried again to reproduce your issue, but could not, choosing
> a specific console type in datacenter->options resulted in the ui
> choosing that (when available) or falling back to the 'best' method
> available
>
> did you maybe try from a different window without refreshing?
> we only check that value once in the beginning, or when you change
> it in the same tab
>
> www/manager6/qemu/Config.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-21 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 13:02 [pve-devel] [PATCH manager] ui: add comment about disabling spice/xterm initially Dominik Csapak
2021-04-21 15:29 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal