all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] ui: tape/ChangerStatus: hide drive-slots without assigned drives
@ 2021-04-14 12:11 Dominik Csapak
  2021-04-14 12:24 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-04-14 12:11 UTC (permalink / raw)
  To: pbs-devel

if a user has not configured a drive for a specified driveslot of the
changer, simply hide that slot

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/ChangerStatus.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index e5d143fe..ff8a436c 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -519,7 +519,11 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 		    let type = entry['entry-kind'];
 		    let id = entry['entry-id'];
 
-		    if (type === 'drive' && drive_entries[id] !== undefined) {
+		    if (type === 'drive') {
+			if (drive_entries[id] === undefined) {
+			    continue;
+			}
+
 			entry = Ext.applyIf(entry, drive_entries[id]);
 			valid_drives.push(drive_entries[id].name);
 		    }
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] ui: tape/ChangerStatus: hide drive-slots without assigned drives
  2021-04-14 12:11 [pbs-devel] [PATCH proxmox-backup] ui: tape/ChangerStatus: hide drive-slots without assigned drives Dominik Csapak
@ 2021-04-14 12:24 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-04-14 12:24 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Dominik Csapak

On 14.04.21 14:11, Dominik Csapak wrote:
> if a user has not configured a drive for a specified driveslot of the
> changer, simply hide that slot
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/tape/ChangerStatus.js | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-14 12:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 12:11 [pbs-devel] [PATCH proxmox-backup] ui: tape/ChangerStatus: hide drive-slots without assigned drives Dominik Csapak
2021-04-14 12:24 ` [pbs-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal