From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: tape: rename erase to format
Date: Wed, 14 Apr 2021 12:21:37 +0200 [thread overview]
Message-ID: <20210414102137.27818-1-d.csapak@proxmox.com> (raw)
erase is a different action, so correctly call it 'format'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/ChangerStatus.js | 6 +++---
www/tape/DriveStatus.js | 2 +-
www/tape/TapeInventory.js | 6 +++---
www/tape/window/Erase.js | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index 2f6e29df..8983c2aa 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -138,7 +138,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
});
},
- erase: function(v, rI, cI, button, el, record) {
+ format: function(v, rI, cI, button, el, record) {
let me = this;
let view = me.getView();
let label = record.data['label-text'];
@@ -703,8 +703,8 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
},
{
iconCls: 'fa fa-trash-o',
- handler: 'erase',
- tooltip: gettext('Erase'),
+ handler: 'format',
+ tooltip: gettext('Format'),
isDisabled: (v, r, c, i, rec) => !rec.data['label-text'],
},
{
diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js
index feca6ede..acc77680 100644
--- a/www/tape/DriveStatus.js
+++ b/www/tape/DriveStatus.js
@@ -215,7 +215,7 @@ Ext.define('PBS.TapeManagement.DriveStatus', {
handler: 'format',
iconCls: 'fa fa-trash-o',
dangerous: true,
- confirmMsg: gettext('Are you sure you want to erase the inserted tape?'),
+ confirmMsg: gettext('Are you sure you want to format the inserted tape?'),
disabled: true,
bind: {
disabled: '{!online}',
diff --git a/www/tape/TapeInventory.js b/www/tape/TapeInventory.js
index 555445ff..749a16c2 100644
--- a/www/tape/TapeInventory.js
+++ b/www/tape/TapeInventory.js
@@ -36,7 +36,7 @@ Ext.define('PBS.TapeManagement.TapeInventory', {
Ext.create('PBS.TapeManagement.LabelMediaWindow').show();
},
- erase: function() {
+ format: function() {
let me = this;
let view = me.getView();
let selection = view.getSelection();
@@ -202,9 +202,9 @@ Ext.define('PBS.TapeManagement.TapeInventory', {
},
{
xtype: 'proxmoxButton',
- text: gettext('Erase'),
+ text: gettext('Format'),
disabled: true,
- handler: 'erase',
+ handler: 'format',
},
],
diff --git a/www/tape/window/Erase.js b/www/tape/window/Erase.js
index 8b166d30..b15b297d 100644
--- a/www/tape/window/Erase.js
+++ b/www/tape/window/Erase.js
@@ -11,7 +11,7 @@ Ext.define('PBS.TapeManagement.EraseWindow', {
return {
singleDrive: me.singleDrive,
hasSingleDrive: !!me.singleDrive,
- warning: Ext.String.format(gettext("Are you sure you want to erase tape '{0}' ?"), me.label),
+ warning: Ext.String.format(gettext("Are you sure you want to format tape '{0}' ?"), me.label),
};
},
--
2.20.1
reply other threads:[~2021-04-14 10:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414102137.27818-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal