From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Oguz Bektas <o.bektas@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] highlight focused button with dark orange
Date: Tue, 13 Apr 2021 13:00:06 +0200 [thread overview]
Message-ID: <20210413130006.4dac276d@rosa.proxmox.com> (raw)
In-Reply-To: <20210412142838.1332059-1-o.bektas@proxmox.com>
Thanks for the patch!
can see that it could help users, who (have to) navigate the installer
with a keyboard...
gave it a (very quick) spin with the check-pve make-target - in
general it seems ok to me
one thing that does not look too nice to me is the +/- buttons for integer
entry (click on Options in the HD selection window) - maybe those could be
a bit more toned down (only change the foreground in that case)
On Mon, 12 Apr 2021 16:28:38 +0200
Oguz Bektas <o.bektas@proxmox.com> wrote:
> idea was from community forum [0]
>
> arbitrary css can be used to style the installer, for now just add the
> highlight feature.
>
> [0]:
> https://forum.proxmox.com/threads/proxmox-installation-eye-catching-color.87440
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> proxinstall | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/proxinstall b/proxinstall
> index 03f6ec7..e79f0c6 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -25,6 +25,13 @@ use POSIX ":sys_wait_h";
>
> use ProxmoxInstallerSetup;
>
> +my $css_provider = Gtk3::CssProvider->new();
> +my $display = Gtk3::Gdk::Display::get_default;
> +my $screen = Gtk3::Gdk::Display::get_default_screen($display);
> +Gtk3::StyleContext::add_provider_for_screen($screen, $css_provider, 600);
> +my $prox_theme = "button:focus {\nbackground-color: #000000;\ncolor: #FF4500;\n}";
> +$css_provider->load_from_data($prox_theme);
> +
> my $setup = ProxmoxInstallerSetup::setup();
>
> my $opt_testmode;
next prev parent reply other threads:[~2021-04-13 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 14:28 Oguz Bektas
2021-04-13 11:00 ` Stoiko Ivanov [this message]
2021-04-14 13:54 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413130006.4dac276d@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal