* [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/DriveStatus: remove buffer-mode
@ 2021-04-13 8:18 Dominik Csapak
2021-04-13 8:18 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/DriveStatus: show that no tape is loaded in grid title Dominik Csapak
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-04-13 8:18 UTC (permalink / raw)
To: pbs-devel
since this will almost always be set to '1', it has no real
value to show to the user
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/DriveStatus.js | 4 ----
1 file changed, 4 deletions(-)
diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js
index f4cfd9ea..d4783560 100644
--- a/www/tape/DriveStatus.js
+++ b/www/tape/DriveStatus.js
@@ -319,10 +319,6 @@ Ext.define('PBS.TapeManagement.DriveStatusGrid', {
defaultValue: false,
renderer: Proxmox.Utils.format_boolean,
},
- 'buffer-mode': {
- required: true,
- header: gettext('Buffer Mode'),
- },
'compression': {
required: true,
header: gettext('Compression'),
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/DriveStatus: show that no tape is loaded in grid title
2021-04-13 8:18 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/DriveStatus: remove buffer-mode Dominik Csapak
@ 2021-04-13 8:18 ` Dominik Csapak
0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2021-04-13 8:18 UTC (permalink / raw)
To: pbs-devel
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/DriveStatus.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js
index d4783560..feca6ede 100644
--- a/www/tape/DriveStatus.js
+++ b/www/tape/DriveStatus.js
@@ -44,6 +44,8 @@ Ext.define('PBS.TapeManagement.DriveStatus', {
let online = statusgrid.getObjectValue('file-number') !== undefined;
let vm = me.getViewModel();
vm.set('online', online);
+ let title = online ? gettext('Status') : gettext('Status (No Tape loaded)');
+ statusgrid.setTitle(title);
},
onStateLoad: function(store) {
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-13 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 8:18 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/DriveStatus: remove buffer-mode Dominik Csapak
2021-04-13 8:18 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/DriveStatus: show that no tape is loaded in grid title Dominik Csapak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal