From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 1/2] ui: network: add columns for vlan-id and vlan-raw-device
Date: Mon, 12 Apr 2021 15:14:37 +0200 [thread overview]
Message-ID: <20210412131438.15859-2-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20210412131438.15859-1-a.lauterer@proxmox.com>
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
There are probably a few opinions if these columns should be hidden by
default and where they should be placed.
src/node/NetworkView.js | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/node/NetworkView.js b/src/node/NetworkView.js
index a1570ce..2e83130 100644
--- a/src/node/NetworkView.js
+++ b/src/node/NetworkView.js
@@ -16,6 +16,8 @@ Ext.define('proxmox-networks', {
'netmask6',
'slaves',
'type',
+ 'vlan-id',
+ 'vlan-raw-device',
],
idProperty: 'iface',
});
@@ -429,6 +431,18 @@ Ext.define('Proxmox.node.NetworkView', {
dataIndex: 'gateway',
renderer: renderer_generator('gateway'),
},
+ {
+ header: gettext('VLAN ID'),
+ hidden: true,
+ sortable: true,
+ dataIndex: 'vlan-id',
+ },
+ {
+ header: gettext('VLAN raw device'),
+ hidden: true,
+ sortable: true,
+ dataIndex: 'vlan-raw-device',
+ },
{
header: gettext('Comment'),
dataIndex: 'comments',
--
2.20.1
next prev parent reply other threads:[~2021-04-12 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 13:14 [pve-devel] [RFC series 0/2] Show more vlan infos Aaron Lauterer
2021-04-12 13:14 ` Aaron Lauterer [this message]
2021-06-15 15:01 ` [pve-devel] applied: [PATCH widget-toolkit 1/2] ui: network: add columns for vlan-id and vlan-raw-device Thomas Lamprecht
2021-04-12 13:14 ` [pve-devel] [PATCH common 2/2] inotify: read_interfaces: add vlan-id and vlan-raw-device on dot notation vlan interfaces Aaron Lauterer
2021-06-15 15:01 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-09 13:38 ` [pve-devel] [RFC series 0/2] Show more vlan infos Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412131438.15859-2-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal