From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 widget-toolkit 3/7] format task status: improve replace() usage
Date: Fri, 9 Apr 2021 10:44:32 +0200 [thread overview]
Message-ID: <20210409084436.2454-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210409084436.2454-1-f.ebner@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
New in v2.
src/Utils.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/Utils.js b/src/Utils.js
index 155ef49..1dd227a 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -741,8 +741,7 @@ utilities: {
switch (parsed) {
case 'unknown': return Proxmox.Utils.unknownText;
case 'error': return Proxmox.Utils.errorText + ': ' + status;
- case 'warning': return Proxmox.Utils.warningsText +
- status.replace('WARNINGS', '');
+ case 'warning': return status.replace('WARNINGS', Proxmox.Utils.warningsText);
case 'ok': // fall-through
default: return status;
}
--
2.20.1
WARNING: multiple messages have this Message-ID
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 widget-toolkit 3/7] format task status: improve replace() usage
Date: Fri, 9 Apr 2021 10:44:32 +0200 [thread overview]
Message-ID: <20210409084436.2454-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210409084436.2454-1-f.ebner@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
New in v2.
src/Utils.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/Utils.js b/src/Utils.js
index 155ef49..1dd227a 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -741,8 +741,7 @@ utilities: {
switch (parsed) {
case 'unknown': return Proxmox.Utils.unknownText;
case 'error': return Proxmox.Utils.errorText + ': ' + status;
- case 'warning': return Proxmox.Utils.warningsText +
- status.replace('WARNINGS', '');
+ case 'warning': return status.replace('WARNINGS', Proxmox.Utils.warningsText);
case 'ok': // fall-through
default: return status;
}
--
2.20.1
next prev parent reply other threads:[~2021-04-09 8:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 8:44 [pve-devel] [PATCH-SERIES v2] improve warnings handling in UI and add to PVE Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] " Fabian Ebner
2021-04-09 8:44 ` [pve-devel] [PATCH v2 widget-toolkit 1/7] task status: create helper for formatting Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] " Fabian Ebner
2021-04-23 12:54 ` [pve-devel] applied: " Thomas Lamprecht
2021-04-23 12:54 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2021-04-09 8:44 ` [pve-devel] [PATCH v2 widget-toolkit 2/7] format task status: rename variable Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] " Fabian Ebner
2021-04-23 12:54 ` [pve-devel] applied: " Thomas Lamprecht
2021-04-23 12:54 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2021-04-09 8:44 ` Fabian Ebner [this message]
2021-04-09 8:44 ` [pbs-devel] [PATCH v2 widget-toolkit 3/7] format task status: improve replace() usage Fabian Ebner
2021-04-23 12:54 ` [pve-devel] applied: " Thomas Lamprecht
2021-04-23 12:54 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2021-04-09 8:44 ` [pve-devel] [PATCH v2 proxmox-backup 4/7] ui: tasks: use format_task_status Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] " Fabian Ebner
2021-04-09 8:44 ` [pve-devel] [PATCH v2 manager 5/7] ui: cluster task log: handle warnings like the node task log does Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] " Fabian Ebner
2021-04-09 8:44 ` [pve-devel] [PATCH/RFC v2 common 6/7] allow workers to count warnings and finish tasks in a WARNINGS state Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] " Fabian Ebner
2021-04-23 12:36 ` [pve-devel] applied: " Thomas Lamprecht
2021-04-23 12:36 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2021-04-09 8:44 ` [pve-devel] [PATCH/RFC v2 container 7/7] restore: sanitize config: use new warn() function Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] " Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409084436.2454-4-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal