* [pve-devel] [PATCH qemu-server] api: migrate: fix variable name
@ 2021-03-23 9:15 Fabian Ebner
2021-03-24 5:54 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2021-03-23 9:15 UTC (permalink / raw)
To: pve-devel
Commit abff03211f28018ce193911173afa39ba1a6ff24 switched to iterating over the
values instead of the keys, but didn't update the variable name. Use target_sid,
because target is already in use for the target node.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/API2/Qemu.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index ea74c69..e95ab13 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3684,8 +3684,8 @@ __PACKAGE__->register_method({
$rpcenv->check_vm_perm($authuser, $vmid, undef, ['VM.Config.Disk'])
if !defined($storagemap->{identity});
- foreach my $source (values %{$storagemap->{entries}}) {
- $check_storage->($source);
+ foreach my $target_sid (values %{$storagemap->{entries}}) {
+ $check_storage->($target_sid);
}
$check_storage->($storagemap->{default})
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server] api: migrate: fix variable name
2021-03-23 9:15 [pve-devel] [PATCH qemu-server] api: migrate: fix variable name Fabian Ebner
@ 2021-03-24 5:54 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-03-24 5:54 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 23.03.21 10:15, Fabian Ebner wrote:
> Commit abff03211f28018ce193911173afa39ba1a6ff24 switched to iterating over the
> values instead of the keys, but didn't update the variable name. Use target_sid,
> because target is already in use for the target node.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/API2/Qemu.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 5:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 9:15 [pve-devel] [PATCH qemu-server] api: migrate: fix variable name Fabian Ebner
2021-03-24 5:54 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal