all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage] fix #3348: Revert "NFS: avoid using obsolete rpcinfo option"
Date: Wed, 17 Mar 2021 10:46:58 +0100	[thread overview]
Message-ID: <20210317094658.29195-1-f.ebner@proxmox.com> (raw)

This reverts commit 816dadb17f8e28d7a0a092c055c0c07b6038e64c.

With '-T' one needs to specify either 'tcp' or 'tcp6', and using 'tcp' doesn't
work for an IPv6-only server. Simply switch back to using '-t', because $server
might also just be a host name, so it's not really worth adding extra code (and
calls) to figure out if it's IPv4 or IPv6 beforehand.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

If preferred, I can send an alternative using
    rpcinfo -l $server nfs 4
but that requires parsing the output.

 PVE/Storage/NFSPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/NFSPlugin.pm b/PVE/Storage/NFSPlugin.pm
index cb16864..72e06c2 100644
--- a/PVE/Storage/NFSPlugin.pm
+++ b/PVE/Storage/NFSPlugin.pm
@@ -166,7 +166,7 @@ sub check_connection {
     if (defined($opts) && $opts =~ /vers=4.*/) {
 	# nfsv4 uses a pseudo-filesystem always beginning with /
 	# no exports are listed
-	$cmd = ['/usr/sbin/rpcinfo', '-T', 'tcp', $server, 'nfs', '4'];
+	$cmd = ['/usr/sbin/rpcinfo', '-t', $server, 'nfs', '4'];
     } else {
 	$cmd = ['/sbin/showmount', '--no-headers', '--exports', $server];
     }
-- 
2.20.1





                 reply	other threads:[~2021-03-17  9:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210317094658.29195-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal