From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 3/3] ui: restore: fix bandwidth limit behavior
Date: Mon, 15 Mar 2021 12:57:29 +0100 [thread overview]
Message-ID: <20210315115729.24381-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210315115729.24381-1-f.ebner@proxmox.com>
by allowing zero and updating the field name. Otherwise the hint mentioning zero
is wrong. Also, it's not only a read limit as the emptyText already indicates.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
www/manager6/window/Restore.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
index d220c7bf..9e47ebd6 100644
--- a/www/manager6/window/Restore.js
+++ b/www/manager6/window/Restore.js
@@ -59,7 +59,8 @@ Ext.define('PVE.window.Restore', {
xtype: 'pveBandwidthField',
name: 'bwlimit',
backendUnit: 'KiB',
- fieldLabel: gettext('Read Limit'),
+ allowZero: true,
+ fieldLabel: gettext('Bandwidth Limit'),
emptyText: gettext('Defaults to target storage restore limit'),
autoEl: {
tag: 'div',
--
2.20.1
next prev parent reply other threads:[~2021-03-15 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 11:57 [pve-devel] [PATCH qemu-server 1/3] restore vma: fix applying storage-specific bandwidth limit Fabian Ebner
2021-03-15 11:57 ` [pve-devel] [PATCH manager 2/3] ui: bandwidth limit selector: make it possible to allow zero Fabian Ebner
2021-03-15 11:57 ` Fabian Ebner [this message]
2021-03-15 12:30 ` [pve-devel] applied-series: [PATCH qemu-server 1/3] restore vma: fix applying storage-specific bandwidth limit Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315115729.24381-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal