From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 container 4/5] config: parse: also allow empty values
Date: Thu, 11 Mar 2021 11:26:49 +0100 [thread overview]
Message-ID: <20210311102650.6730-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210311102650.6730-1-f.ebner@proxmox.com>
because they are valid for '-list' formats and it makes the behavior match with
what we do for VM configs. The new pattern is the same that is used for VM
configs. Because it is a non-greedy pattern, trailing whitespaces will not be
included in the value anymore. This /should/ cause no problems and the '\s*$'
at the end suggests that that is how it was intended in the first place.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
No changes from v1.
src/PVE/LXC/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 5d223b2..de7e924 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -933,7 +933,7 @@ sub parse_pct_config {
} else {
warn "vm $vmid - property 'delete' is only allowed in [pve:pending]\n";
}
- } elsif ($line =~ m/^([a-z][a-z_]*\d*):\s*(\S.*)\s*$/) {
+ } elsif ($line =~ m/^([a-z][a-z_]*\d*):\s*(.+?)\s*$/) {
my $key = $1;
my $value = $2;
eval { $value = PVE::LXC::Config->check_type($key, $value); };
--
2.20.1
next prev parent reply other threads:[~2021-03-11 10:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 10:26 [pve-devel] [PATCH-SERIES v2] small improvements for parsing and printing Fabian Ebner
2021-03-11 10:26 ` [pve-devel] [PATCH v2 manager 1/5] ui: avoid errors when 'template' property is not present in guest status Fabian Ebner
2021-03-15 13:00 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-11 10:26 ` [pve-devel] [PATCH v2 qemu-server 2/5] vmstatus: make template property optional Fabian Ebner
2021-03-15 13:00 ` Thomas Lamprecht
2021-05-26 8:57 ` Fabian Ebner
2021-05-26 15:41 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-11 10:26 ` [pve-devel] [PATCH v2 container 3/5] " Fabian Ebner
2021-03-15 13:01 ` Thomas Lamprecht
2021-03-16 8:04 ` Fabian Ebner
2021-05-26 15:41 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-11 10:26 ` Fabian Ebner [this message]
2021-03-15 13:24 ` [pve-devel] applied: [PATCH v2 container 4/5] config: parse: also allow empty values Thomas Lamprecht
2021-03-11 10:26 ` [pve-devel] [RFC/PATCH v2 container 5/5] vmstatus: make lock property optional again Fabian Ebner
2021-03-15 13:42 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311102650.6730-5-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal