all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] applied: [PATCH backup] d/postinst: restart when updating from older version
@ 2021-03-11  8:58 Thomas Lamprecht
  0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2021-03-11  8:58 UTC (permalink / raw)
  To: pbs-devel

Else one has quite a terrible UX when installing from 1.0 ISO and
then upgrading to latest release..

commit 0ec79339f7aebf9 for the fix and some other details

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

As without this we always get a hanging upgrade when doing the insitial
upgrade after installation from the ISO, that's a no go, and restart is
better than user botching around, not really knowing what the issue is
and needing to do a stop+start or restart anyway.

 debian/postinst | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/debian/postinst b/debian/postinst
index 7af49952..eb79851f 100644
--- a/debian/postinst
+++ b/debian/postinst
@@ -12,7 +12,14 @@ case "$1" in
 	# modeled after dh_systemd_start output
 	systemctl --system daemon-reload >/dev/null || true
 	if [ -n "$2" ]; then
-		_dh_action=try-reload-or-restart
+		if dpkg --compare-versions "$2" 'lt' '1.0.7-1'; then
+			# there was an issue with reloading and systemd being confused in older daemon versions
+			# so restart instead of reload if upgrading from there, see commit 0ec79339f7aebf9
+			# FIXME: remove with PBS 2.1
+			_dh_action=try-restart
+		else
+			_dh_action=try-reload-or-restart
+		fi
 	else
 		_dh_action=start
 	fi
-- 
2.29.2





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-11  8:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11  8:58 [pbs-devel] applied: [PATCH backup] d/postinst: restart when updating from older version Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal