From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 manager 2/3] partially fix #2745: vzdump: use default for remove parameter
Date: Wed, 3 Mar 2021 12:50:41 +0100 [thread overview]
Message-ID: <20210303115042.22061-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210303115042.22061-1-f.ebner@proxmox.com>
The initial default from the $confdesc is 1 anyways, and like
this changing the default in /etc/vzdump.conf to 0 actually works.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/VZDump.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 0345d2f3..02858d8e 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -449,8 +449,6 @@ sub new {
my $defaults = read_vzdump_defaults();
- $opts->{remove} = 1 if !defined($opts->{remove});
-
foreach my $k (keys %$defaults) {
next if $k eq 'exclude-path' || $k eq 'prune-backups'; # dealt with separately
if ($k eq 'dumpdir' || $k eq 'storage') {
--
2.20.1
next prev parent reply other threads:[~2021-03-03 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 11:50 [pve-devel] [PATCH v2 guest-common 1/3] mention prune behavior for the " Fabian Ebner
2021-03-03 11:50 ` Fabian Ebner [this message]
2021-03-05 20:34 ` [pve-devel] applied: [PATCH v2 manager 2/3] partially fix #2745: vzdump: use default for " Thomas Lamprecht
2021-03-03 11:50 ` [pve-devel] [PATCH v2 manager 3/3] fix #2745: ui: backup: allow users to specify remove=1 Fabian Ebner
2021-03-05 20:34 ` Thomas Lamprecht
2021-03-09 10:28 ` Fabian Ebner
2021-03-09 10:53 ` Fabian Ebner
2021-03-05 20:34 ` [pve-devel] applied: [PATCH v2 guest-common 1/3] mention prune behavior for the remove parameter Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303115042.22061-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.