all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 1/4] vmstatus: make boolean value explicit
Date: Wed,  3 Mar 2021 12:01:25 +0100	[thread overview]
Message-ID: <20210303110128.9244-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210303110128.9244-1-f.ebner@proxmox.com>

as otherwise the empty string is printed with 'qm status <id> --verbose' when
it's not a template.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a498444..43d7c6b 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2621,7 +2621,7 @@ sub vmstatus {
 	$d->{diskread} = 0;
 	$d->{diskwrite} = 0;
 
-        $d->{template} = PVE::QemuConfig->is_template($conf);
+        $d->{template} = PVE::QemuConfig->is_template($conf) ? 1 : 0;
 
 	$d->{serial} = 1 if conf_has_serial($conf);
 	$d->{lock} = $conf->{lock} if $conf->{lock};
-- 
2.20.1





  reply	other threads:[~2021-03-03 11:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 11:01 [pve-devel] [PATCH-SERIES] small improvements for parsing and printing Fabian Ebner
2021-03-03 11:01 ` Fabian Ebner [this message]
2021-03-03 16:53   ` [pve-devel] [PATCH qemu-server 1/4] vmstatus: make boolean value explicit Thomas Lamprecht
2021-03-04  8:04     ` Fabian Ebner
2021-03-04  8:59       ` Fabian Ebner
2021-03-03 11:01 ` [pve-devel] [PATCH qemu-server 2/4] config: parse: also warn about invalid lines Fabian Ebner
2021-03-03 16:51   ` [pve-devel] applied: " Thomas Lamprecht
2021-03-03 11:01 ` [pve-devel] [PATCH container 3/4] vmstatus: make boolean value explicit Fabian Ebner
2021-03-03 16:53   ` Thomas Lamprecht
2021-03-03 11:01 ` [pve-devel] [PATCH container 4/4] config: parse: also allow empty values Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210303110128.9244-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal