all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/1] ui: zpool status detail: add default for scrub information
Date: Thu, 25 Feb 2021 22:23:05 +0100	[thread overview]
Message-ID: <20210225212305.17954-3-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20210225212305.17954-1-s.ivanov@proxmox.com>

in case a zpool has not been yet scrubbed, there is no 'scan'
information in `zpool status` output.

Adding a informational text in that case might help users to notice
that something is not configured optimally (e.g. disabled cronjob)

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 www/manager6/node/ZFS.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js
index b54fb4e7..749d7c9b 100644
--- a/www/manager6/node/ZFS.js
+++ b/www/manager6/node/ZFS.js
@@ -294,6 +294,7 @@ Ext.define('PVE.node.ZFSStatus', {
 	me.rows = {
 	    scan: {
 		header: gettext('Scan'),
+		defaultValue: gettext('No information available (Pool has not been scrubbed yet?)'),
 	    },
 	    status: {
 		header: gettext('Status'),
-- 
2.20.1





  parent reply	other threads:[~2021-02-25 21:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 21:23 [pve-devel] [PATCH storage/manager] fix cosmetic api issue with zpool status output Stoiko Ivanov
2021-02-25 21:23 ` [pve-devel] [PATCH storage 1/1] disks: zfs: scan is only returned optionally Stoiko Ivanov
2021-02-26  8:10   ` [pve-devel] applied: " Thomas Lamprecht
2021-02-25 21:23 ` Stoiko Ivanov [this message]
2021-02-26  8:17   ` [pve-devel] applied: [PATCH manager 1/1] ui: zpool status detail: add default for scrub information Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210225212305.17954-3-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal