[pve-devel] [PATCH storage/manager] fix cosmetic api issue with zpool status output

[pve-devel] [PATCH storage/manager] fix cosmetic api issue with zpool status output

[Stoiko Ivanov]

As reported in a thread in our community forum:
https://forum.proxmox.com/threads/zfs-storage-detail-produces-result-verification-failed-400-error.84839/#post-372939

the 'scan' property of the API call (a.k.a. the scan-line in zpool status
output) is not present, if a pool has never been scrubbed.

the patch for pve-storage fixes the issue of failed result verification.
the patch for pve-manager is optional, but I thought that a pool, that never
has been scrubbed is worth an informational notice.

pve-storage:
Stoiko Ivanov (1):
  disks: zfs: scan is only returned optionally

 PVE/API2/Disks/ZFS.pm | 1 +
 1 file changed, 1 insertion(+)

pve-manager:
Stoiko Ivanov (1):
  ui: zpool status detail: add default for scrub information

 www/manager6/node/ZFS.js | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

[pve-devel] [PATCH storage 1/1] disks: zfs: scan is only returned optionally

[Stoiko Ivanov]

the line is not present if a zpool has never been scrubbed before
(e.g. if it's freshly setup)

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 PVE/API2/Disks/ZFS.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/API2/Disks/ZFS.pm b/PVE/API2/Disks/ZFS.pm
index 2884bb0..b815ee7 100644
--- a/PVE/API2/Disks/ZFS.pm
+++ b/PVE/API2/Disks/ZFS.pm
@@ -163,6 +163,7 @@ __PACKAGE__->register_method ({
 		description => 'Information about the recommended action to fix the state.',
 	    },
 	    scan => {
+		optional => 1,
 		type => 'string',
 		description => 'Information about the last/current scrub.',
 	    },
-- 
2.20.1

[pve-devel] applied: [PATCH storage 1/1] disks: zfs: scan is only returned optionally

[Thomas Lamprecht]

On 25.02.21 22:23, Stoiko Ivanov wrote:
> the line is not present if a zpool has never been scrubbed before
> (e.g. if it's freshly setup)
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  PVE/API2/Disks/ZFS.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!

[pve-devel] [PATCH manager 1/1] ui: zpool status detail: add default for scrub information

[Stoiko Ivanov]

in case a zpool has not been yet scrubbed, there is no 'scan'
information in `zpool status` output.

Adding a informational text in that case might help users to notice
that something is not configured optimally (e.g. disabled cronjob)

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 www/manager6/node/ZFS.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js
index b54fb4e7..749d7c9b 100644
--- a/www/manager6/node/ZFS.js
+++ b/www/manager6/node/ZFS.js
@@ -294,6 +294,7 @@ Ext.define('PVE.node.ZFSStatus', {
 	me.rows = {
 	    scan: {
 		header: gettext('Scan'),
+		defaultValue: gettext('No information available (Pool has not been scrubbed yet?)'),
 	    },
 	    status: {
 		header: gettext('Status'),
-- 
2.20.1

[pve-devel] applied: [PATCH manager 1/1] ui: zpool status detail: add default for scrub information

[Thomas Lamprecht]

On 25.02.21 22:23, Stoiko Ivanov wrote:
> in case a zpool has not been yet scrubbed, there is no 'scan'
> information in `zpool status` output.
> 
> Adding a informational text in that case might help users to notice
> that something is not configured optimally (e.g. disabled cronjob)
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  www/manager6/node/ZFS.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks! Changed the gettext to an existing translation, namely "No Data",
IMO enough here.