From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH zfsonlinux 4/4] buildsys: validate ABI at build time
Date: Wed, 24 Feb 2021 22:08:02 +0100 [thread overview]
Message-ID: <20210224210802.8425-5-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20210224210802.8425-1-s.ivanov@proxmox.com>
this commit follows: 93661343d884a5339631afd7b683e232d20b7baf and
0b52b09c6083bd590e46cb9884d06bae1b712a2a from debian-upstream [0].
the `make checkabi` invocation takes < .4s on my workstation - so it
seems worth the change.
[0] https://salsa.debian.org/zfsonlinux-team/zfs
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
debian/control | 3 ++-
debian/rules | 6 ++++++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 4ab6bda4..619244e9 100644
--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,8 @@ Source: zfs-linux
Section: contrib/kernel
Priority: optional
Maintainer: Proxmox Support Team <support@proxmox.com>
-Build-Depends: debhelper (>= 10~),
+Build-Depends: abigail-tools,
+ debhelper (>= 10~),
dh-python,
libblkid-dev,
libelf-dev,
diff --git a/debian/rules b/debian/rules
index fe09e2e1..836e4bc4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -47,6 +47,12 @@ override_dh_auto_configure:
done
override_dh_auto_test:
+override_dh_auto_test:
+ifeq (amd64,$(DEB_HOST_ARCH))
+ # Upstream provides an ABI guarantee that we validate here
+ $(MAKE) checkabi
+endif
+
# The dh_auto_test rule is disabled because
# `make check` cannot run in an unprivileged build environment.
--
2.20.1
next prev parent reply other threads:[~2021-02-24 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 21:07 [pve-devel] [PATCH zfsonlinux 0/4] match library package names with d.o. and minor cleanups Stoiko Ivanov
2021-02-24 21:07 ` [pve-devel] [PATCH zfsonlinux 1/4] d/control: match package names to debian-upstream Stoiko Ivanov
2021-02-24 21:08 ` [pve-devel] [PATCH zfsonlinux 2/4] d/rules: cosmetic cleanups minimize diff with d.o Stoiko Ivanov
2021-02-24 21:08 ` [pve-devel] [PATCH zfsonlinux 3/4] d/rules: drop unneeded UDEB conditionals Stoiko Ivanov
2021-02-24 21:08 ` Stoiko Ivanov [this message]
2021-02-25 11:14 ` [pve-devel] applied-series: [PATCH zfsonlinux 0/4] match library package names with d.o. and minor cleanups Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224210802.8425-5-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.