all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: do not show progressbar for (un)load
Date: Tue, 23 Feb 2021 09:06:33 +0100	[thread overview]
Message-ID: <20210223080633.8392-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210223080633.8392-1-d.csapak@proxmox.com>

since we already show the state of the drive in the grid, this is
not necessary

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/ChangerStatus.js | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index fcf4d6dd..8be600d8 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -134,7 +134,6 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 		submitText: gettext('OK'),
 		title: gettext('Load Media into Drive'),
 		url: `/api2/extjs/tape/drive`,
-		showProgress: true,
 		method: 'POST',
 		submitUrl: function(url, values) {
 		    let drive = values.drive;
@@ -168,21 +167,15 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 	    let me = this;
 	    let drive = record.data.name;
 	    try {
-		let response = await PBS.Async.api2({
+		await PBS.Async.api2({
 		    method: 'POST',
 		    timeout: 5*60*1000,
 		    url: `/api2/extjs/tape/drive/${encodeURIComponent(drive)}/unload`,
 		});
-
-		Ext.create('Proxmox.window.TaskProgress', {
-		    autoShow: true,
-		    upid: response.result.data,
-		    taskDone: () => me.reload(),
-		});
 	    } catch (error) {
 		Ext.Msg.alert(gettext('Error'), error);
-		me.reload();
 	    }
+	    me.reload();
 	},
 
 	driveCommand: function(driveid, command, callback, params, method) {
-- 
2.20.1





  reply	other threads:[~2021-02-23  8:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23  8:06 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields Dominik Csapak
2021-02-23  8:06 ` Dominik Csapak [this message]
2021-02-23  8:11   ` [pbs-devel] applied: [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: do not show progressbar for (un)load Dietmar Maurer
2021-02-23  8:10 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223080633.8392-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal