all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/4] ui: tape/ChangerStatus: convert grid stores to DiffStores
Date: Mon, 22 Feb 2021 14:25:36 +0100	[thread overview]
Message-ID: <20210222132537.7407-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210222132537.7407-1-d.csapak@proxmox.com>

to not deselect items when the store is updated

this makes the ui a bit better to use

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/ChangerStatus.js | 43 +++++++++++++++++++++++++++++++++++----
 1 file changed, 39 insertions(+), 4 deletions(-)

diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index aae13e43..11b159ce 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -1,3 +1,16 @@
+Ext.define('pbs-slot-model', {
+    extend: 'Ext.data.Model',
+    fields: ['entry-id', 'label-text', 'is-labeled', ' model', 'name', 'vendor', 'serial', 'state',
+	{
+	    name: 'is-blocked',
+	    calculate: function(data) {
+		return data.state !== undefined;
+	    },
+	},
+    ],
+    idProperty: 'entry-id',
+});
+
 Ext.define('PBS.TapeManagement.ChangerStatus', {
     extend: 'Ext.panel.Panel',
     alias: 'widget.pbsChangerStatus',
@@ -500,10 +513,18 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 		    data[type].push(entry);
 		}
 
+		// the stores are diffstores and are only refreshed
+		// on a 'load' event, which does not trigger on 'setData'
+		// so we have to fire them ourselves
 
-		me.lookup('slots').getStore().setData(data.slot);
-		me.lookup('import_export').getStore().setData(data['import-export']);
-		me.lookup('drives').getStore().setData(data.drive);
+		me.lookup('slots').getStore().rstore.setData(data.slot);
+		me.lookup('slots').getStore().rstore.fireEvent('load', me, [], true);
+
+		me.lookup('import_export').getStore().rstore.setData(data['import-export']);
+		me.lookup('import_export').getStore().rstore.fireEvent('load', me, [], true);
+
+		me.lookup('drives').getStore().rstore.setData(data.drive);
+		me.lookup('drives').getStore().rstore.fireEvent('load', me, [], true);
 
 		if (!use_cache) {
 		    Proxmox.Utils.setErrorMask(view);
@@ -638,6 +659,11 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 		    padding: 5,
 		    flex: 1,
 		    store: {
+			type: 'diff',
+			rstore: {
+			    type: 'store',
+			    model: 'pbs-slot-model',
+			},
 			data: [],
 		    },
 		    columns: [
@@ -697,7 +723,11 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 			    reference: 'drives',
 			    title: gettext('Drives'),
 			    store: {
-				fields: ['entry-id', 'label-text', 'model', 'name', 'vendor', 'serial'],
+				type: 'diff',
+				rstore: {
+				    type: 'store',
+				    model: 'pbs-slot-model',
+				},
 				data: [],
 			    },
 			    columns: [
@@ -803,6 +833,11 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 			    xtype: 'grid',
 			    reference: 'import_export',
 			    store: {
+				type: 'diff',
+				rstore: {
+				    type: 'store',
+				    model: 'pbs-slot-model',
+				},
 				data: [],
 			    },
 			    title: gettext('Import-Export Slots'),
-- 
2.20.1





  parent reply	other threads:[~2021-02-22 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 13:25 [pbs-devel] [PATCH proxmox-backup 1/4] ui: tape/ChangerStatus: only show loading on 'force refresh' Dominik Csapak
2021-02-22 13:25 ` [pbs-devel] [PATCH proxmox-backup 2/4] ui: tape/ChangerStatus: reload changer status (cached) every 5000ms Dominik Csapak
2021-02-22 13:25 ` Dominik Csapak [this message]
2021-02-22 13:25 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: tape/ChangerStatus: disable drive buttons when it's blocked Dominik Csapak
2021-02-23  8:07 ` [pbs-devel] applied: [PATCH proxmox-backup 1/4] ui: tape/ChangerStatus: only show loading on 'force refresh' Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210222132537.7407-3-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal