all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/3] ui: tape/TapeInventory: add 'Add Tape' button
Date: Mon, 15 Feb 2021 15:22:22 +0100	[thread overview]
Message-ID: <20210215142223.11140-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210215142223.11140-1-d.csapak@proxmox.com>

by adapting and reusing the 'LabelMedia' window

shows a short notice about inserting the correct tape in the drive
and now allows to select a drive

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/TapeInventory.js     |  8 ++++++++
 www/tape/window/LabelMedia.js | 36 ++++++++++++++++++++++++-----------
 2 files changed, 33 insertions(+), 11 deletions(-)

diff --git a/www/tape/TapeInventory.js b/www/tape/TapeInventory.js
index c641e492..25dea1ba 100644
--- a/www/tape/TapeInventory.js
+++ b/www/tape/TapeInventory.js
@@ -29,6 +29,10 @@ Ext.define('PBS.TapeManagement.TapeInventory', {
     controller: {
 	xclass: 'Ext.app.ViewController',
 
+	addTape: function() {
+	    Ext.create('PBS.TapeManagement.LabelMediaWindow').show();
+	},
+
 	moveToVault: function() {
 	    let me = this;
 	    let view = me.getView();
@@ -92,6 +96,10 @@ Ext.define('PBS.TapeManagement.TapeInventory', {
 	    handler: 'reload',
 	},
 	'-',
+	{
+	    text: gettext('Add Tape'),
+	    handler: 'addTape',
+	},
 	{
 	    xtype: 'proxmoxButton',
 	    text: gettext('Set Tape Location'),
diff --git a/www/tape/window/LabelMedia.js b/www/tape/window/LabelMedia.js
index 563f59f0..b3dd8f48 100644
--- a/www/tape/window/LabelMedia.js
+++ b/www/tape/window/LabelMedia.js
@@ -8,16 +8,41 @@ Ext.define('PBS.TapeManagement.LabelMediaWindow', {
     title: gettext('Label Media'),
     submitText: gettext('OK'),
 
+    url: '/api2/extjs/tape/drive/',
+
+    cbindData: function(config) {
+	let me = this;
+	return {
+	    driveid: config.driveid,
+	};
+    },
+
     method: 'POST',
 
     showProgress: true,
 
+    submitUrl: function(url, values) {
+	let driveid = encodeURIComponent(values.drive);
+	delete values.drive;
+	return `${url}/${driveid}/label-media`;
+    },
+
     items: [
 	{
 	    xtype: 'displayfield',
+	    cls: 'pmx-hint',
+	    value: gettext('Make sure that the correct tape is inserted the selected drive and type in the label written on the tape.'),
+	},
+	{
+	    xtype: 'pmxDisplayEditField',
 	    fieldLabel: gettext('Drive'),
+	    name: 'drive',
+	    editConfig: {
+		xtype: 'pbsDriveSelector',
+	    },
 	    cbind: {
 		value: '{driveid}',
+		editable: '{!driveid}',
 	    },
 	},
 	{
@@ -34,16 +59,5 @@ Ext.define('PBS.TapeManagement.LabelMediaWindow', {
 	    skipEmptyText: true,
 	},
     ],
-
-    initComponent: function() {
-	let me = this;
-	if (!me.driveid) {
-	    throw "no driveid given";
-	}
-
-	let driveid = encodeURIComponent(me.driveid);
-	me.url = `/api2/extjs/tape/drive/${driveid}/label-media`;
-	me.callParent();
-    },
 });
 
-- 
2.20.1





  reply	other threads:[~2021-02-15 14:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 14:22 [pbs-devel] [PATCH proxmox-backup 1/3] ui: tape/TapeInventory: change to regular store Dominik Csapak
2021-02-15 14:22 ` Dominik Csapak [this message]
2021-02-15 14:22 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: tape/TapeManagement: change Text of Backup/Tape Inventory Dominik Csapak
2021-02-16  7:34 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] ui: tape/TapeInventory: change to regular store Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210215142223.11140-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal