all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 0/7] ui: qemu/HardwareView: fix GUI permission checks and make eslint happier
Date: Mon,  1 Feb 2021 15:21:24 +0100	[thread overview]
Message-ID: <20210201142131.30024-1-a.lauterer@proxmox.com> (raw)

This series fixes two permission checks in the HardwareView panel:

* Add -> EFI Disk button
* Edit button for CDROM drives

to only show them as enabled if the necessary permissions are available.

Additionally it contains a few patches to make eslint happy.

Aaron Lauterer (7):
  ui: qemu/HardwareView: eslint: enforce "no-mixed-operators" rule
  ui: qemu/HardwareView: eslint: enforce "max-len" rule
  ui: qemu/HardwareView: eslint: enforce "no-useless-concat" rule
  ui: qemu/HardwareView: eslint: enforce "no-shadow" rule
  ui: qemu/HardwareView: change heuristic perms to const
  ui: qemu/HardwareView: check EFI Disk button permissions
  ui: qemu/HardwareView: add CDROM permission check to edit button

 www/manager6/qemu/HardwareView.js | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

-- 
2.20.1





             reply	other threads:[~2021-02-01 14:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 14:21 Aaron Lauterer [this message]
2021-02-01 14:21 ` [pve-devel] [PATCH manager 1/7] ui: qemu/HardwareView: eslint: enforce "no-mixed-operators" rule Aaron Lauterer
2021-02-03  7:37   ` [pve-devel] applied: " Thomas Lamprecht
2021-02-01 14:21 ` [pve-devel] [PATCH manager 2/7] ui: qemu/HardwareView: eslint: enforce "max-len" rule Aaron Lauterer
2021-02-03  7:40   ` Thomas Lamprecht
2021-02-03  9:50     ` Aaron Lauterer
2021-02-03  9:54       ` Aaron Lauterer
2021-02-01 14:21 ` [pve-devel] [PATCH manager 3/7] ui: qemu/HardwareView: eslint: enforce "no-useless-concat" rule Aaron Lauterer
2021-02-02 13:06   ` Dominik Csapak
2021-02-03  5:11     ` Thomas Lamprecht
2021-02-01 14:21 ` [pve-devel] [PATCH manager 4/7] ui: qemu/HardwareView: eslint: enforce "no-shadow" rule Aaron Lauterer
2021-02-02 13:07   ` Dominik Csapak
2021-02-03  6:18     ` Thomas Lamprecht
2021-02-01 14:21 ` [pve-devel] [PATCH manager 5/7] ui: qemu/HardwareView: change heuristic perms to const Aaron Lauterer
2021-02-03  7:37   ` [pve-devel] applied: " Thomas Lamprecht
2021-02-01 14:21 ` [pve-devel] [PATCH manager 6/7] ui: qemu/HardwareView: check EFI Disk button permissions Aaron Lauterer
2021-02-03  7:37   ` [pve-devel] applied: " Thomas Lamprecht
2021-02-01 14:21 ` [pve-devel] [PATCH manager 7/7] ui: qemu/HardwareView: add CDROM permission check to edit button Aaron Lauterer
2021-02-02 13:13   ` Dominik Csapak
2021-02-02 13:41     ` Aaron Lauterer
2021-02-03  6:21       ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201142131.30024-1-a.lauterer@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal