all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/4] api2/types/tape/drive: add changer_slot
Date: Mon, 25 Jan 2021 16:30:56 +0100	[thread overview]
Message-ID: <20210125153057.30061-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210125153057.30061-1-d.csapak@proxmox.com>

so that an api user can see which drive belongs to which slot of a changer

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/api2/config/changer.rs   | 1 +
 src/api2/config/drive.rs     | 1 +
 src/api2/types/tape/drive.rs | 4 ++++
 3 files changed, 6 insertions(+)

diff --git a/src/api2/config/changer.rs b/src/api2/config/changer.rs
index c1e8c59e..3a838504 100644
--- a/src/api2/config/changer.rs
+++ b/src/api2/config/changer.rs
@@ -137,6 +137,7 @@ pub fn list_changers(
             name: changer.name,
             path: changer.path.clone(),
             changer: None,
+            changer_slot: None,
             vendor: None,
             model: None,
             serial: None,
diff --git a/src/api2/config/drive.rs b/src/api2/config/drive.rs
index 7a05238b..76092c49 100644
--- a/src/api2/config/drive.rs
+++ b/src/api2/config/drive.rs
@@ -127,6 +127,7 @@ pub fn list_drives(
             name: drive.name,
             path: drive.path.clone(),
             changer: drive.changer,
+            changer_slot: drive.changer_drive_id,
             vendor: None,
             model: None,
             serial: None,
diff --git a/src/api2/types/tape/drive.rs b/src/api2/types/tape/drive.rs
index 6e5e3b15..cc2d5d63 100644
--- a/src/api2/types/tape/drive.rs
+++ b/src/api2/types/tape/drive.rs
@@ -82,6 +82,7 @@ pub struct LinuxTapeDrive {
 
 #[api()]
 #[derive(Serialize,Deserialize)]
+#[serde(rename_all = "kebab-case")]
 /// Drive list entry
 pub struct DriveListEntry {
     /// Drive name
@@ -91,6 +92,9 @@ pub struct DriveListEntry {
     /// Associated changer device
     #[serde(skip_serializing_if="Option::is_none")]
     pub changer: Option<String>,
+    /// Slot in associated changer device
+    #[serde(skip_serializing_if="Option::is_none")]
+    pub changer_slot: Option<u64>,
     /// Vendor (autodetected)
     #[serde(skip_serializing_if="Option::is_none")]
     pub vendor: Option<String>,
-- 
2.20.1





  parent reply	other threads:[~2021-01-25 15:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 15:30 [pbs-devel] [PATCH proxmox-backup 1/4] docs/tape: fix some typos and improve wording Dominik Csapak
2021-01-25 15:30 ` [pbs-devel] [PATCH proxmox-backup 2/4] tape: fix typos Dominik Csapak
2021-01-26 11:42   ` Dietmar Maurer
2021-01-25 15:30 ` Dominik Csapak [this message]
2021-01-26 11:43   ` [pbs-devel] [PATCH proxmox-backup 3/4] api2/types/tape/drive: add changer_slot Dietmar Maurer
2021-01-26 12:10     ` Dominik Csapak
2021-01-26 14:19       ` Dietmar Maurer
2021-01-25 15:30 ` [pbs-devel] [PATCH proxmox-backup 4/4] api2/tape/changer: reorganize api Dominik Csapak
2021-01-26 11:48   ` Dietmar Maurer
2021-01-26 11:42 ` [pbs-devel] [PATCH proxmox-backup 1/4] docs/tape: fix some typos and improve wording Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125153057.30061-3-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal