all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Oguz Bektas <o.bektas@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: add missing uri encoding in user edit and view
Date: Tue, 19 Jan 2021 14:33:23 +0100	[thread overview]
Message-ID: <20210119133323.1420136-1-o.bektas@proxmox.com> (raw)

userid parameter needs to be properly encoded when shown on the browser

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 www/config/UserView.js | 2 ++
 www/window/UserEdit.js | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/config/UserView.js b/www/config/UserView.js
index 4645737a..ae313776 100644
--- a/www/config/UserView.js
+++ b/www/config/UserView.js
@@ -139,6 +139,8 @@ Ext.define('PBS.config.UserView', {
 	    xtype: 'proxmoxStdRemoveButton',
 	    baseurl: '/access/users/',
 	    enableFn: (rec) => rec.data.userid !== 'root@pam',
+	    getUrl: (rec) =>
+		`/access/users/${encodeURIComponent(rec.getId())}`,
 	    callback: 'reload',
 	},
 	'-',
diff --git a/www/window/UserEdit.js b/www/window/UserEdit.js
index aaae835f..06ec5377 100644
--- a/www/window/UserEdit.js
+++ b/www/window/UserEdit.js
@@ -20,7 +20,7 @@ Ext.define('PBS.window.UserEdit', {
 	var baseurl = '/api2/extjs/access/users';
 
 	me.isCreate = !userid;
-	me.url = userid ? baseurl + '/' + userid : baseurl;
+	me.url = userid ? baseurl + '/' + encodeURIComponent(userid) : baseurl;
 	me.method = userid ? 'PUT' : 'POST';
 	me.autoLoad = !!userid;
 
-- 
2.20.1




             reply	other threads:[~2021-01-19 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 13:33 Oguz Bektas [this message]
2021-01-25 15:13 ` Dominik Csapak
2021-01-26  9:54 ` [pbs-devel] applied: " Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210119133323.1420136-1-o.bektas@proxmox.com \
    --to=o.bektas@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal