From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api 1/5] api: statistics: remove unneeded RESTEnvironment
Date: Fri, 15 Jan 2021 10:46:21 +0100 [thread overview]
Message-ID: <20210115094626.25440-2-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20210115094626.25440-1-s.ivanov@proxmox.com>
none of the API calls in PMG::API2::Statistics use the
RESTEnvironment - so remove the unused code.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/PMG/API2/Statistics.pm | 34 ----------------------------------
1 file changed, 34 deletions(-)
diff --git a/src/PMG/API2/Statistics.pm b/src/PMG/API2/Statistics.pm
index 7eb8d18..adc7650 100644
--- a/src/PMG/API2/Statistics.pm
+++ b/src/PMG/API2/Statistics.pm
@@ -238,9 +238,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $cfg = PMG::Config->new();
@@ -383,9 +380,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $stat = PMG::Statistic->new($start, $end);
@@ -530,9 +524,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $cfg = PMG::Config->new();
@@ -684,9 +675,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $stat = PMG::Statistic->new($start, $end);
@@ -791,9 +779,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $stat = PMG::Statistic->new($start, $end);
@@ -910,8 +895,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
-
my $hours = $param->{hours} // 12;
my $span = $param->{timespan} // 1800;
@@ -972,8 +955,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
-
my $hours = $param->{hours} // 12;
my $limit = $param->{limit} // 5;
@@ -1071,9 +1052,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $span = $param->{timespan} // 3600;
@@ -1138,9 +1116,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $stat = PMG::Statistic->new($start, $end);
@@ -1185,9 +1160,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $stat = PMG::Statistic->new($start, $end);
@@ -1284,9 +1256,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $stat = PMG::Statistic->new($start, $end);
@@ -1345,9 +1314,6 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
- my $restenv = PMG::RESTEnvironment->get();
- my $cinfo = $restenv->{cinfo};
-
my ($start, $end) = $extract_start_end->($param);
my $span = $param->{timespan} // 3600;
--
2.20.1
next prev parent reply other threads:[~2021-01-15 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 9:46 [pmg-devel] [PATCH pmg-api/pmg-gui] allow / in local part of pmg-email-address Stoiko Ivanov
2021-01-15 9:46 ` Stoiko Ivanov [this message]
2021-01-15 9:46 ` [pmg-devel] [PATCH pmg-api 2/5] api: statistics: refactor return for detail calls Stoiko Ivanov
2021-01-15 9:46 ` [pmg-devel] [PATCH pmg-api 3/5] api: statistics: refactor " Stoiko Ivanov
2021-01-15 9:46 ` [pmg-devel] [PATCH pmg-api 4/5] api: statistics: make email a parameter Stoiko Ivanov
2021-01-15 9:46 ` [pmg-devel] [PATCH pmg-api 5/5] utils: allow '/' inside email address localpart Stoiko Ivanov
2021-01-15 9:46 ` [pmg-devel] [PATCH pmg-gui 1/1] statistics: use new api call for detailed stats Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115094626.25440-2-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.