all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] fix #3245: only use default schedule for new jobs
Date: Tue, 12 Jan 2021 10:21:17 +0100	[thread overview]
Message-ID: <20210112092117.22444-1-d.csapak@proxmox.com> (raw)

an empty schedule means 'none', so do not fill it with the default
in case we edit an existing job (like we do already for sync jobs)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/window/VerifyJobEdit.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/window/VerifyJobEdit.js b/www/window/VerifyJobEdit.js
index 2a22e3d6..40db207d 100644
--- a/www/window/VerifyJobEdit.js
+++ b/www/window/VerifyJobEdit.js
@@ -23,6 +23,7 @@ Ext.define('PBS.window.VerifyJobEdit', {
 	me.isCreate = !id;
 	me.url = id ? `${baseurl}/${id}` : baseurl;
 	me.method = id ? 'PUT' : 'POST';
+	me.scheduleValue = id ? null : 'daily';
 	me.autoLoad = !!id;
 	me.editDatastore = me.datastore === undefined && me.isCreate;
 	return { };
@@ -64,8 +65,8 @@ Ext.define('PBS.window.VerifyJobEdit', {
 		name: 'schedule',
 		fieldLabel: gettext('Schedule'),
 		emptyText: gettext('none (disabled)'),
-		value: 'daily',
 		cbind: {
+		    value: '{scheduleValue}',
 		    deleteEmpty: '{!isCreate}',
 		},
 	    },
-- 
2.20.1





             reply	other threads:[~2021-01-12  9:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  9:21 Dominik Csapak [this message]
2021-01-12  9:54 ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210112092117.22444-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal