all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] ui: firewall: Clarify text for "Add" button
Date: Tue,  5 Jan 2021 12:00:33 +0100	[thread overview]
Message-ID: <20210105110033.37620-2-d.jaeger@proxmox.com> (raw)
In-Reply-To: <20210105110033.37620-1-d.jaeger@proxmox.com>

The regular button is titled "Add".  If groups are allowed, then the group
button is titled "Add: Group rule".  In this case, changing the regular button
title to "Add: Rule" makes the difference a little more clear and also both
buttons then look the same.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
 www/manager6/grid/FirewallRules.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js
index 08deee2a..3ad41b10 100644
--- a/www/manager6/grid/FirewallRules.js
+++ b/www/manager6/grid/FirewallRules.js
@@ -529,7 +529,9 @@ Ext.define('PVE.FirewallRules', {
 	});
 
 	me.addBtn =  Ext.create('Ext.Button', {
-	    text: gettext('Add'),
+	    // Make difference between regular rule and group rule clear
+	    text: gettext('Add') +
+		(me.allow_groups ? ": " + gettext('Rule') : ""),
 	    disabled: true,
 	    handler: function() {
 		var win = Ext.create('PVE.FirewallRuleEdit', {
-- 
2.20.1




      reply	other threads:[~2021-01-05 11:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 11:00 [pve-devel] [PATCH manager 1/2] ui: firewall: Clarify group rule subjects Dominic Jäger
2021-01-05 11:00 ` Dominic Jäger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105110033.37620-2-d.jaeger@proxmox.com \
    --to=d.jaeger@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal