all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: improve description of guest-fstrim checkbox
Date: Tue, 15 Dec 2020 16:22:04 +0100	[thread overview]
Message-ID: <20201215152204.1659-2-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20201215152204.1659-1-a.lauterer@proxmox.com>

The phrasing left some room to speculation when this would actually be
run, e.g. after cloning a full VM?

Currently the only instances where it is used is after moving a disk or
migrating a VM.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 www/manager6/form/AgentFeatureSelector.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
index 122c8713..6c21306f 100644
--- a/www/manager6/form/AgentFeatureSelector.js
+++ b/www/manager6/form/AgentFeatureSelector.js
@@ -14,7 +14,7 @@ Ext.define('PVE.form.AgentFeatureSelector', {
 	},
 	{
 	    xtype: 'proxmoxcheckbox',
-	    boxLabel: gettext('Run guest-trim after clone disk'),
+	    boxLabel: gettext('Run guest-trim after a disk move or VM migration'),
 	    name: 'fstrim_cloned_disks',
 	    bind: {
 		disabled: '{!enabled.checked}',
-- 
2.20.1





  reply	other threads:[~2020-12-15 15:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 15:22 [pve-devel] [PATCH qemu-server] improve description of fstrim_cloned_disks Aaron Lauterer
2020-12-15 15:22 ` Aaron Lauterer [this message]
2020-12-16  7:20   ` [pve-devel] [PATCH manager] ui: improve description of guest-fstrim checkbox Thomas Lamprecht
2020-12-16 10:27     ` Aaron Lauterer
2020-12-18 16:55   ` [pve-devel] applied: " Thomas Lamprecht
2020-12-18 16:55 ` [pve-devel] applied: Re: [PATCH qemu-server] improve description of fstrim_cloned_disks Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201215152204.1659-2-a.lauterer@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal