From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] improve description of fstrim_cloned_disks
Date: Tue, 15 Dec 2020 16:22:03 +0100 [thread overview]
Message-ID: <20201215152204.1659-1-a.lauterer@proxmox.com> (raw)
The phrasing left some room for speculation when this would be triggered.
E.g. after cloning a full VM?
Currently the only instances where it is used is when a disk is moved or
a VM migrated.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 70c14ba..e3f9551 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -156,7 +156,7 @@ my $agent_fmt = {
default_key => 1,
},
fstrim_cloned_disks => {
- description => "Run fstrim after cloning/moving a disk.",
+ description => "Run fstrim after moving a disk or migrating the VM.",
type => 'boolean',
optional => 1,
default => 0
--
2.20.1
next reply other threads:[~2020-12-15 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 15:22 Aaron Lauterer [this message]
2020-12-15 15:22 ` [pve-devel] [PATCH manager] ui: improve description of guest-fstrim checkbox Aaron Lauterer
2020-12-16 7:20 ` Thomas Lamprecht
2020-12-16 10:27 ` Aaron Lauterer
2020-12-18 16:55 ` [pve-devel] applied: " Thomas Lamprecht
2020-12-18 16:55 ` [pve-devel] applied: Re: [PATCH qemu-server] improve description of fstrim_cloned_disks Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215152204.1659-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal