From: Dietmar Maurer <dietmar@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATH proxmox-backup] fix bug #3189: fix change_password permission checks, run protected
Date: Sat, 5 Dec 2020 16:22:57 +0100 [thread overview]
Message-ID: <20201205152257.6002-1-dietmar@proxmox.com> (raw)
---
src/api2/access.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/api2/access.rs b/src/api2/access.rs
index 3b59b3d3..2f7fb6ec 100644
--- a/src/api2/access.rs
+++ b/src/api2/access.rs
@@ -181,6 +181,7 @@ fn create_ticket(
}
#[api(
+ protected: true,
input: {
properties: {
userid: {
@@ -195,7 +196,6 @@ fn create_ticket(
description: "Anybody is allowed to change there own password. In addition, users with 'Permissions:Modify' privilege may change any password.",
permission: &Permission::Anybody,
},
-
)]
/// Change user password
///
@@ -215,7 +215,7 @@ fn change_password(
let mut allowed = userid == current_user;
- if userid == "root@pam" { allowed = true; }
+ if current_user == "root@pam" { allowed = true; }
if !allowed {
let user_info = CachedUserInfo::new()?;
--
2.20.1
reply other threads:[~2020-12-05 15:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205152257.6002-1-dietmar@proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.