From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 qemu-server 4/5] migration: sort volumes migrated with storage_migrate
Date: Tue, 1 Dec 2020 13:07:01 +0100 [thread overview]
Message-ID: <20201201120702.3869-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20201201120702.3869-1-f.ebner@proxmox.com>
Having a deterministic order here is useful for testing.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
New in v3.
PVE/QemuMigrate.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 97af397..5c019fc 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -610,7 +610,7 @@ sub sync_disks {
$self->log('info', "copying local disk images") if scalar(%$local_volumes);
- foreach my $volid (keys %$local_volumes) {
+ foreach my $volid (sort keys %$local_volumes) {
my ($sid, $volname) = PVE::Storage::parse_volume_id($volid);
my $targetsid = PVE::QemuServer::map_storage($self->{opts}->{storagemap}, $sid);
my $ref = $local_volumes->{$volid}->{ref};
--
2.20.1
next prev parent reply other threads:[~2020-12-01 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 12:06 [pve-devel] [PATCH-SERIES v3] migration tests Fabian Ebner
2020-12-01 12:06 ` [pve-devel] [PATCH v3 container 1/5] use new move_config_to_node method Fabian Ebner
2020-12-01 12:06 ` [pve-devel] [PATCH v3 qemu-server 2/5] " Fabian Ebner
2020-12-01 12:07 ` [pve-devel] [PATCH v3 qemu-server 3/5] migration: factor out starting remote tunnel Fabian Ebner
2020-12-01 12:07 ` Fabian Ebner [this message]
2020-12-01 12:07 ` [pve-devel] [PATCH v3 qemu-server 5/5] create test environment for migration Fabian Ebner
2020-12-15 15:20 ` [pve-devel] applied-series: [PATCH-SERIES v3] migration tests Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201120702.3869-5-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal