From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/4] gc: shorten progress messages
Date: Mon, 30 Nov 2020 16:22:17 +0100 [thread overview]
Message-ID: <20201130152220.658777-2-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20201130152220.658777-1-f.gruenbichler@proxmox.com>
we have messages starting the phases anyway, and limit the number of
progress updates so that context remains available at all times.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/backup/chunk_store.rs | 2 +-
src/backup/datastore.rs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backup/chunk_store.rs b/src/backup/chunk_store.rs
index 59719bad..34d6f655 100644
--- a/src/backup/chunk_store.rs
+++ b/src/backup/chunk_store.rs
@@ -301,7 +301,7 @@ impl ChunkStore {
last_percentage = percentage;
crate::task_log!(
worker,
- "percentage done: phase2 {}% (processed {} chunks)",
+ "processed {}% ({} chunks)",
percentage,
chunk_count,
);
diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
index 19efc23f..b199f11f 100644
--- a/src/backup/datastore.rs
+++ b/src/backup/datastore.rs
@@ -505,7 +505,7 @@ impl DataStore {
if percentage > last_percentage {
crate::task_log!(
worker,
- "percentage done: phase1 {}% ({} of {} index files)",
+ "marked {}% ({} of {} index files)",
percentage,
done,
image_count,
--
2.20.1
next prev parent reply other threads:[~2020-11-30 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 15:22 [pbs-devel] [PATCH proxmox-backup 0/4] GC cleanups Fabian Grünbichler
2020-11-30 15:22 ` Fabian Grünbichler [this message]
2020-11-30 15:22 ` [pbs-devel] [PATCH proxmox-backup 2/4] gc: log index files found outside of expected scheme Fabian Grünbichler
2020-11-30 15:22 ` [pbs-devel] [PATCH proxmox-backup 3/4] gc: remove duplicate variable Fabian Grünbichler
2020-11-30 15:22 ` [pbs-devel] [RFC proxmox-backup 4/4] gc: don't limit index listing to same filesystem Fabian Grünbichler
2020-12-01 5:24 ` [pbs-devel] applied: [PATCH proxmox-backup 0/4] GC cleanups Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130152220.658777-2-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.