From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-container 3/3] cgroup: get_subdir: return cgroupv2 path for undef controller
Date: Tue, 24 Nov 2020 11:45:41 +0100 [thread overview]
Message-ID: <20201124104541.jw6l4fcmmiva3kf3@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20201030094228.53423-4-aderumier@odiso.com>
On Fri, Oct 30, 2020 at 10:42:28AM +0100, Alexandre Derumier wrote:
> ---
> src/PVE/LXC/CGroup.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/PVE/LXC/CGroup.pm b/src/PVE/LXC/CGroup.pm
> index 19562c2..74d84c4 100644
> --- a/src/PVE/LXC/CGroup.pm
> +++ b/src/PVE/LXC/CGroup.pm
> @@ -35,6 +35,7 @@ sub get_subdir {
> my $path = $entry->{$kind};
>
> return $path if defined $path;
> + return "/lxc/$self->{vmid}" if !$controller;
Why exactly are you doing this? `get_cgroup_path` should work with an
undef $controller value. Also, this ignores the $limiting parameter (and
the main point for using the command socket was to not hardcode paths at
all)
So what kind of problem did you run into there?
>
> $path = PVE::LXC::Command::get_cgroup_path(
> $self->{vmid},
> --
> 2.20.1
next prev parent reply other threads:[~2020-11-24 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 9:42 [pve-devel] [PATCH pve-container 0/3] use generic CGroup module Alexandre Derumier
2020-10-30 9:42 ` [pve-devel] [PATCH pve-container 1/3] Cgroups: use base PVE::CGroup and keep specific lxc code Alexandre Derumier
2020-10-30 9:42 ` [pve-devel] [PATCH pve-container 2/3] use PVE::CGroup Alexandre Derumier
2020-10-30 9:42 ` [pve-devel] [PATCH pve-container 3/3] cgroup: get_subdir: return cgroupv2 path for undef controller Alexandre Derumier
2020-11-24 10:45 ` Wolfgang Bumiller [this message]
2020-11-24 10:51 ` [pve-devel] partially applied series: [PATCH pve-container 0/3] use generic CGroup module Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124104541.jw6l4fcmmiva3kf3@wobu-vie.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.