Re: [pbs-devel] [RFC backup 6/6] gui: tfa support

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

2 notes:

On Thu, Nov 19, 2020 at 03:56:08PM +0100, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
>  www/LoginView.js             | 323 +++++++++++++++++++++++++++++++++--
>  www/Makefile                 |   6 +
>  www/OnlineHelpInfo.js        |  36 ----
>  www/Utils.js                 |  59 +++++++
>  www/config/TfaView.js        | 322 ++++++++++++++++++++++++++++++++++
>  www/index.hbs                |   1 +
>  www/panel/AccessControl.js   |   6 +
>  www/window/AddTfaRecovery.js | 211 +++++++++++++++++++++++
>  www/window/AddTotp.js        | 283 ++++++++++++++++++++++++++++++
>  www/window/AddWebauthn.js    | 193 +++++++++++++++++++++
>  www/window/TfaEdit.js        |  92 ++++++++++
>  11 files changed, 1478 insertions(+), 54 deletions(-)
>  create mode 100644 www/config/TfaView.js
>  create mode 100644 www/window/AddTfaRecovery.js
>  create mode 100644 www/window/AddTotp.js
>  create mode 100644 www/window/AddWebauthn.js
>  create mode 100644 www/window/TfaEdit.js
> 
> diff --git a/www/Makefile b/www/Makefile
> index 1df2195a..86e0516e 100644
> --- a/www/Makefile
> +++ b/www/Makefile
> @@ -16,12 +16,16 @@ JSSRC=							\
>  	data/RunningTasksStore.js			\
>  	button/TaskButton.js				\
>  	config/UserView.js				\
> +	config/TfaView.js				\
>  	config/TokenView.js				\
>  	config/RemoteView.js				\
>  	config/ACLView.js				\
>  	config/SyncView.js				\
>  	config/VerifyView.js				\
>  	window/ACLEdit.js				\
> +	window/AddTfaRecovery.js			\
> +	window/AddTotp.js				\
> +	window/AddWebauthn.js				\
>  	window/BackupFileDownloader.js			\
>  	window/BackupGroupChangeOwner.js		\
>  	window/CreateDirectory.js			\
> @@ -34,6 +38,7 @@ JSSRC=							\
>  	window/UserEdit.js				\
>  	window/UserPassword.js				\
>  	window/TokenEdit.js				\
> +	window/TfaEdit.js				\
>  	window/VerifyJobEdit.js				\
>  	window/ZFSCreate.js				\
>  	dashboard/DataStoreStatistics.js		\
> @@ -100,6 +105,7 @@ install: js/proxmox-backup-gui.js css/ext6-pbs.css index.hbs
>  	install -m644 index.hbs $(DESTDIR)$(JSDIR)/
>  	install -dm755 $(DESTDIR)$(JSDIR)/js
>  	install -m644 js/proxmox-backup-gui.js $(DESTDIR)$(JSDIR)/js/
> +	install -m 0644 qrcode.min.js $(DESTDIR)$(JSDIR)/

FYI this is a leftover from before the this was packaged separately,
needs to be removed when building a package without the file present.

>  	install -dm755 $(DESTDIR)$(JSDIR)/css
>  	install -m644 css/ext6-pbs.css $(DESTDIR)$(JSDIR)/css/
>  	install -dm755 $(DESTDIR)$(JSDIR)/images
> diff --git a/www/OnlineHelpInfo.js b/www/OnlineHelpInfo.js
> index aee73bf6..c54912d8 100644
> --- a/www/OnlineHelpInfo.js
> +++ b/www/OnlineHelpInfo.js

The changs in this file were a build artifact...?

> @@ -75,42 +75,6 @@ const proxmoxOnlineHelpInfo = {
>      "link": "/docs/pve-integration.html#pve-integration",
>      "title": "`Proxmox VE`_ Integration"
>    },
> -  "rst-primer": {
> -    "link": "/docs/reStructuredText-primer.html#rst-primer",
> -    "title": "reStructuredText Primer"
> -  },
> -  "rst-inline-markup": {
> -    "link": "/docs/reStructuredText-primer.html#rst-inline-markup",
> -    "title": "Inline markup"
> -  },
> -  "rst-literal-blocks": {
> -    "link": "/docs/reStructuredText-primer.html#rst-literal-blocks",
> -    "title": "Literal blocks"
> -  },
> -  "rst-doctest-blocks": {
> -    "link": "/docs/reStructuredText-primer.html#rst-doctest-blocks",
> -    "title": "Doctest blocks"
> -  },
> -  "rst-tables": {
> -    "link": "/docs/reStructuredText-primer.html#rst-tables",
> -    "title": "Tables"
> -  },
> -  "rst-field-lists": {
> -    "link": "/docs/reStructuredText-primer.html#rst-field-lists",
> -    "title": "Field Lists"
> -  },
> -  "rst-roles-alt": {
> -    "link": "/docs/reStructuredText-primer.html#rst-roles-alt",
> -    "title": "Roles"
> -  },
> -  "rst-directives": {
> -    "link": "/docs/reStructuredText-primer.html#rst-directives",
> -    "title": "Directives"
> -  },
> -  "html-meta": {
> -    "link": "/docs/reStructuredText-primer.html#html-meta",
> -    "title": "HTML Metadata"
> -  },
>    "storage-disk-management": {
>      "link": "/docs/storage.html#storage-disk-management",
>      "title": "Disk Management"